New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template site to default markdown renderer #961

Merged
merged 1 commit into from Apr 13, 2013

Conversation

Projects
None yet
3 participants
@benbalter
Contributor

benbalter commented Apr 13, 2013

The template site created by jekyll new specifies rdiscount as the default rendering engine which is confusing for two reasons:

  1. Why would the default Jekyll site recommend something other than the default?
  2. For someone installing Jekyll for the first time, they're not going to have rdiscount installed, which means on first run, Jekyll's going to err out, which is a pretty bad user experience. We want things to be as smooth as possible for people just getting started.

Removed the line from the config file letting Jekyll to fall back to its default, and things look to render just fine.

@parkr

This comment has been minimized.

Member

parkr commented Apr 13, 2013

Does the new site generate properly? Visually, I mean.

@benbalter

This comment has been minimized.

Contributor

benbalter commented Apr 13, 2013

Looks good to me.

Screen Shot 2013-04-13 at 1 25 05 PM

Screen Shot 2013-04-13 at 1 25 09 PM

parkr added a commit that referenced this pull request Apr 13, 2013

Merge pull request #961 from benbalter/default-markdown-engine
Move template site to default markdown renderer

@parkr parkr merged commit 9b5ebb8 into jekyll:master Apr 13, 2013

1 check passed

default The Travis build passed
Details

@benbalter benbalter deleted the benbalter:default-markdown-engine branch Apr 13, 2013

parkr added a commit that referenced this pull request Apr 13, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.