Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minima 2.1.1 couldn't show tables properly #188

Closed
HackingGate opened this issue Jan 24, 2018 · 2 comments
Closed

minima 2.1.1 couldn't show tables properly #188

HackingGate opened this issue Jan 24, 2018 · 2 comments

Comments

@HackingGate
Copy link
Contributor

HackingGate commented Jan 24, 2018

Table shows properly on local Jekyll server, but not on online server(Hosted by GitHub pages).

I copy-pasted an table example from kramdown doc.

|-----------------+------------+-----------------+----------------|
| Default aligned |Left aligned| Center aligned  | Right aligned  |
|-----------------|:-----------|:---------------:|---------------:|
| First body part |Second cell | Third cell      | fourth cell    |
| Second line     |foo         | **strong**      | baz            |
| Third line      |quux        | baz             | bar            |
|-----------------+------------+-----------------+----------------|
| Second body     |            |                 |                |
| 2 line          |            |                 |                |
|=================+============+=================+================|
| Footer row      |            |                 |                |
|-----------------+------------+-----------------+----------------|

Works fine on local Jekyll. But online server shows like:

table

I checked my Gemfile

# This will help ensure the proper Jekyll version is running.
# Happy Jekylling!
gem "jekyll", "~> 3.7.0"

# This is the default theme for new Jekyll sites. You may change this to anythi\
ng you like.
gem "minima", "~> 2.2.0"

# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
# gem "github-pages", group: :jekyll_plugins

Then uncommented gem "github-pages", group: :jekyll_plugins, commented gem "jekyll", "~> 3.7.0"
After bundle update I got

Bundler could not find compatible versions for gem "minima":
  In Gemfile:
    minima (~> 2.2.0)

    github-pages was resolved to 175, which depends on
      minima (= 2.1.1)

The gem github-pages (175) is forcing me to use minima (2.1.1). If I change my Gemfile to minima (2.1.1). My local Jekyll server will gets the same situation as online server which couldn't show tables properly.

Is this means that GitHub is using minima (2.1.1) or older when generating pages?

I'm not familiar with Web developing. I just created a new Jekyll project. And didn't modified any .css files.

I think this issue will be solved when github-pages releases a new gem version.

But I don't understand why I can't get table works on minima (2.1.1).

Is there anyway to solve the problem?

@ashmaroli
Copy link
Member

ashmaroli commented Jan 24, 2018

Is this means that GitHub is using minima (2.1.1) or older when generating pages?

Yes. GitHub Pages is still using the older version. Check this link to know what its using: https://pages.github.com/versions/

Is there anyway to solve the problem?

There is.. but it requires a bit of work..

@DirtyF
Copy link
Member

DirtyF commented Jan 27, 2018

Should be fixed with latest release.

@DirtyF DirtyF closed this as completed Jan 27, 2018
@DirtyF DirtyF changed the title gihub-pages minima (2.1.1) couldn't show tables properly minima 2.1.1 couldn't show tables properly Jan 27, 2018
h8nor pushed a commit to h8nor/post that referenced this issue Mar 10, 2018
Design disappeared: table, table tr: nth-child (even), table th, table td (bad practice using a remote theme)
:link: jekyll/minima#188
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants