Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 page from jekyll `master` #121

Merged
merged 1 commit into from Apr 8, 2017
Merged

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Apr 8, 2017

Now that Minima is live on Github Pages and Jekyll itself will provide this template from v3.5, let's display the custom 404.html instead of using the one provided by Github

@DirtyF
DirtyF approved these changes Apr 8, 2017
Copy link
Member

DirtyF left a comment

LGTM

@benbalter

This comment has been minimized.

Copy link
Contributor

benbalter commented Apr 8, 2017

@jekyllbot: merge +minor.

Thanks @ashmaroli!

@jekyllbot jekyllbot merged commit 0f03bee into jekyll:master Apr 8, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyllbot added a commit that referenced this pull request Apr 8, 2017
domingohui added a commit to domingohui/minima that referenced this pull request Apr 14, 2017
Merge pull request 121
domingohui added a commit to domingohui/minima that referenced this pull request Apr 14, 2017
@adamvoss

This comment has been minimized.

Copy link

adamvoss commented Jun 9, 2017

When using the minima gem with GitHub Pages, am I correct this file needs to be explicitly duplicated in the site's repo? That is, the version in the gem will not be served?

@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Jun 9, 2017

am I correct this file needs to be explicitly duplicated in the site's repo? That is, the version in the gem will not be served?

@adamvoss Yes. This file is not part of the theme-gem. I intended it to demo the new 404.html page that'll be shipped with Jekyll v3.5. Sorry for not mentioning it explicitly. Once J-3.5 is out, all new projects will have this page included automatically. For existing projects, its left to the owner's discretion.

@ashmaroli ashmaroli deleted the ashmaroli:404-page branch Jun 9, 2017
antgel added a commit to antgel/minima that referenced this pull request Jul 16, 2017
antgel added a commit to antgel/minima that referenced this pull request Jul 16, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.