Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick footer for short posts #223

Merged
merged 1 commit into from Apr 1, 2018
Merged

Stick footer for short posts #223

merged 1 commit into from Apr 1, 2018

Conversation

@DirtyF
Copy link
Member

DirtyF commented Mar 30, 2018

Fix #222

minima-stick-footer

Fix #222
@DirtyF DirtyF added the enhancement label Mar 31, 2018
@DirtyF DirtyF requested a review from jekyll/minima Mar 31, 2018
@ashmaroli

This comment has been minimized.

Copy link
Member

ashmaroli commented Mar 31, 2018

LGTM! 👍

@montyf

This comment has been minimized.

Copy link

montyf commented Mar 31, 2018

Why not apply flex: 1; to .post-content as well?

Edit: Nevermind. I thought post-content corresponded to the post.html layout and page-content to page.html. However, I see that this isn't the case, and that only page-content needs the new attribute. I think the naming is a little confusing.

I just tried this solution and it worked for my blog! It's much simpler than the previous solution I had and doesn't require knowing the size of the footer beforehand.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 31, 2018

Nice! I have never seen the flex properties. Are they cross-browser compatible?

@DirtyF

This comment has been minimized.

Copy link
Member Author

DirtyF commented Mar 31, 2018

@parkr
parkr approved these changes Mar 31, 2018
@DirtyF DirtyF merged commit be3a0a1 into master Apr 1, 2018
3 checks passed
3 checks passed
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DirtyF DirtyF deleted the push-footer branch Apr 1, 2018
@jekyllbot jekyllbot mentioned this pull request Apr 10, 2018
@jekyll jekyll locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.