Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skins to be defined and customized easily #336

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Jan 16, 2019

Related to #335

Summary

  • Rewrite the original minima.scss as minima-classic.scss default skin (codename: "classic").
  • All color-related Sass definitions have been extracted into minima-classic.scss.
  • assets/css/style.scss simply loads a skin based on user's config settings (defaults to the "classic" skin).
  • Syntax-highlighting is embedded in "the skin" since it is primarily color-related and should be adjusted harmoniously in every "skin".
  • The "skin" then loads the non-color related styles and partials.
  • The "skin" also loads a new placeholder partial that allows user to override bundled styles without affecting the upstream updates on the other partials.
@ashmaroli ashmaroli added this to the 3.0 milestone Jan 16, 2019
@ashmaroli ashmaroli requested a review from jekyll/minima Jan 16, 2019
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jan 16, 2019

I'd love to see documentation updates for this in the README! Adding a custom _sass/minima/custom.scss file, making changes to variables, etc.

@DirtyF
DirtyF approved these changes Nov 15, 2019
@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Nov 15, 2019

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit 631461a into jekyll:master Nov 15, 2019
6 checks passed
6 checks passed
Header rules - jekyll-minima No header rules processed
Details
Pages changed - jekyll-minima 3 new files uploaded
Details
Redirect rules - jekyll-minima No redirect rules processed
Details
Mixed content - jekyll-minima No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyll-minima/deploy-preview Deploy preview ready!
Details
jekyllbot added a commit that referenced this pull request Nov 15, 2019
@ashmaroli ashmaroli deleted the ashmaroli:minima-skinable branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.