Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for scalar 'author' configuration #384

Merged
merged 3 commits into from Jan 22, 2020

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Jul 1, 2019

Resolves #357

Since we're onto Minima 3.0, there's no need to support both site.author and site.author.name and instead lets move forward to just render site.author.name.
Similarly, site.email would now be site.author.email.

/cc @travisdowns

@ashmaroli ashmaroli added this to the 3.0 milestone Jul 1, 2019
@ashmaroli ashmaroli requested a review from jekyll/minima Jul 1, 2019
@travisdowns

This comment has been minimized.

Copy link

travisdowns commented Sep 1, 2019

To clarify, does Minima 3 currently support site.author.name (ie, non-scalar author) today?

That is, I am not sure whether this is about removing scalar author support only, or if non-scalar author support also still needs to be added.

If non-scalar is already supported it would be nice since I could update to minima 3 now to resolve my linked issue.

@travisdowns

This comment has been minimized.

Copy link

travisdowns commented Nov 2, 2019

@ashmaroli - any update on this one? Do you expect it to get merged for minima 3?

@DirtyF
DirtyF approved these changes Jan 22, 2020
@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Jan 22, 2020

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit b31d67d into jekyll:master Jan 22, 2020
6 checks passed
6 checks passed
Header rules - jekyll-minima No header rules processed
Details
Pages changed - jekyll-minima 2 new files uploaded
Details
Redirect rules - jekyll-minima No redirect rules processed
Details
Mixed content - jekyll-minima No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyll-minima/deploy-preview Deploy preview ready!
Details
@jekyllbot jekyllbot added the feature label Jan 22, 2020
jekyllbot added a commit that referenced this pull request Jan 22, 2020
@ashmaroli ashmaroli deleted the ashmaroli:author-metadata branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.