Solarized skins

[sandervoerman]

Hi all,
I have created two skins, using the method proposed in #336. Both skins use the Solarized color scheme, one in light mode and the other in dark mode.

minima-solarized

click here for minima-solarized theme preview

minima-solarized-dark

click here for minima-solarized-dark theme preview

[ashmaroli]

Since this uses commits from PR #336, that PR needs to be reviewed and merged first..

[sandervoerman]

Thanks @DirtyF, @ashmaroli!

Since this uses commits from PR #336, that PR needs to be reviewed and merged first..

I understand. I am happy to update this PR should further changes be made to PR #336 (other/different variables, etc).

[ashmaroli]

@sandervoerman #336 has been merged. You may update this branch.
Additionally, it'd be better if you could limit the whitespace for alignment in minima-solarized.scss to the current block. i.e. The skin color scheme values need not align with the values in section about Minima color scheme values

[sandervoerman]

Additionally, it'd be better if you could limit the whitespace for alignment in minima-solarized.scss to the current block. i.e. The skin color scheme values need not align with the values in section about Minima color scheme values

Done!

[ashmaroli]

@sandervoerman The header cells for a table are rendered with a lighter border in the solarized-dark skin. Is that intentional or a bug?

[sandervoerman]

@sandervoerman The header cells for a table are rendered with a lighter border in the solarized-dark skin. Is that intentional or a bug?

It is not intentional, but I think the bug is in _base.scss: while it sets the table border color to $table-border-color, that is overruled for td elements by the td border color, which is set to $brand-color-light. The latter has the same value as the former in the classic skin, but not in the solarized skins.

The commit I just pushed would fix this (for all skins) by setting the td border property to $table-border-color as well (which I am guessing was your intention when defining the $table-border-color variable).

After this commit, the borders all have the same color in solarized-dark:

[ashmaroli]

Thank you very much for working on this @sandervoerman

@jekyllbot: merge +minor