Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder of favicons #433

Merged
merged 3 commits into from Jan 16, 2020
Merged

Add a placeholder of favicons #433

merged 3 commits into from Jan 16, 2020

Conversation

hszhakka
Copy link
Contributor

Add a placeholder of favicons, so that users do not need to override the whole head.html to configure favicons, instead, just override favicons.html.

@ashmaroli
Copy link
Member

I like the intention here. It would be better if the include contained some markup so that novice users don't have to search the internet to add the basic markup themselves..

Also, instead of leaving an HTML comment, I feel it'd be better (even if it would have an effect on the build time for large sites) if it was a Liquid comment (within {% comment %}{% endcomment %}) so that it doesn't get injected into the final HTML file.

@hszhakka
Copy link
Contributor Author

Liquid comment

Good! I have modified it.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It would prevent 404 for missing favicons.
Should we point people to https://realfavicongenerator.net for them to learn about favicons?

@hszhakka
Copy link
Contributor Author

Nice. It would prevent 404 for missing favicons.
Should we point people to https://realfavicongenerator.net for them to learn about favicons?

Good advice. I have added the guide steps to the comment.

@ashmaroli
Copy link
Member

Thank you @hszhakka
@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 27d1d40 into jekyll:master Jan 16, 2020
jekyllbot added a commit that referenced this pull request Jan 16, 2020
@jekyll jekyll locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants