Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename favicons.html to custom-head.html #468

Merged
merged 6 commits into from
Feb 17, 2020

Conversation

hszhakka
Copy link
Contributor

Users may not only want to add favicons in the head but also add anything they want, so rename favicons.html to custom-head.html can indicate the purpose of the template file.

@ashmaroli
Copy link
Member

Sounds good to me. @hszhakka Please update the relevant areas in README.md as well.

@hszhakka
Copy link
Contributor Author

Sounds good to me. @hszhakka Please update the relevant areas in README.md as well.

OK, I have updated it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ashmaroli
Copy link
Member

OK, I have updated it.

There is one other place where you need to mention this:
https://github.com/jekyll/minima#includes

hszhakka and others added 3 commits February 17, 2020 16:19
Co-Authored-By: Ashwin Maroli <ashmaroli@users.noreply.github.com>
Co-Authored-By: Ashwin Maroli <ashmaroli@users.noreply.github.com>
@hszhakka
Copy link
Contributor Author

There is one other place where you need to mention this:

Mentioned.

@ashmaroli
Copy link
Member

@jekyllbot: merge +minor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants