Skip to content

Add auto skin which honors the prefers-color-scheme media query - #634

Merged
jekyllbot merged 14 commits into
jekyll:masterfrom
sandervoerman:prefers-color-scheme
Sep 4, 2022
Merged

jekyllbot merged 14 commits into
jekyll:masterfrom
sandervoerman:prefers-color-scheme

Conversation

@sandervoerman

@sandervoerman sandervoerman commented Jan 9, 2022 •

Copy link
Copy Markdown
Contributor

This is a follow-up to #594, and adds the following changes:

  • the auto skin renders in light or dark mode depending on the prefers-color-scheme media query;
  • code has been refactored so that auto and classic share the same color definitions for light mode, and auto and dark for dark mode.

Screenshots:

auto skin, on Windows 10 in light mode:

jlight

auto skin, on Windows 10 in dark mode:
jdark

@ashmaroli

Copy link
Copy Markdown
Member

Couple of comments:

  • The name classic was selected to denote legacy appearance (Minima 2 n older). Having it switch to a dark mode doesn't sit nicely with me. How about --- auto, classic, dark..?
  • The table details for the new variants include duplicate info. IMO, you could move that to an anchored section below the table and link to the section in the description cells.

@sandervoerman

sandervoerman commented Jan 9, 2022 •

Copy link
Copy Markdown
Contributor Author

The name classic was selected to denote legacy appearance (Minima 2 n older). Having it switch to a dark mode doesn't sit nicely with me. How about --- auto, classic, dark..?

Sure! What would become the default skin, then? auto or classic?

- 'classic' is always light
- 'auto' uses the media query
@ashmaroli

Copy link
Copy Markdown
Member

What would become the default skin, then? auto or classic?

classic for now since it is probably what consumers of this theme via jekyll-remote-theme plugin expects. Lets not shock them right away.

Once we come up with a way to demo the skins on every OS / browser, we may / can switch to auto being the default, or may not, at all. However, if we decide to cut a new release before that, it'll remain classic.
IMO, this shouldn't be a one-person decision.

@ashmaroli

Copy link
Copy Markdown
Member

Um.. To reduce duplication or conflict from #594 getting merged before this, lets not make changes to the README on this branch just yet.. Let the document be finalized there first.

@sandervoerman

Copy link
Copy Markdown
Contributor Author

ok sorry! 😅

@sandervoerman sandervoerman changed the title Allow classic skin to honor prefers-color-scheme media query Add auto skin which honors the prefers-color-scheme media query Jan 9, 2022
@ashmaroli ashmaroli changed the title Add auto skin which honors the prefers-color-scheme media query Add auto skin which honors the prefers-color-scheme media query Jan 9, 2022
@ashmaroli
ashmaroli marked this pull request as draft January 9, 2022 18:26
@DoodlesEpic

Copy link
Copy Markdown

Closes #660
Any reason why this hasn't gotten any updates?

@sandervoerman

Copy link
Copy Markdown
Contributor Author

Any reason why this hasn't gotten any updates?

I think this PR is waiting for #594 which in turn is waiting for review...

@mattr-

mattr- commented Jul 13, 2022

Copy link
Copy Markdown
Member

#594 has been merged, so this PR can be updated against the lateest master and be moved out of draft mode when it's ready.

@sandervoerman
sandervoerman marked this pull request as ready for review July 26, 2022 07:19
@sandervoerman

Copy link
Copy Markdown
Contributor Author

@mattr- Ready now, let me know if you need anything else.

@mattr-

mattr- commented Sep 4, 2022

Copy link
Copy Markdown
Member

@jekyllbot: merge +minor

@jekyllbot
jekyllbot merged commit d54be44 into jekyll:master Sep 4, 2022
jekyllbot added a commit that referenced this pull request Sep 4, 2022
@jekyll jekyll locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants