Skip to content

Add some Oracle compatibility #43

Merged
merged 3 commits into from Mar 21, 2012

2 participants

@kissifrot

This adds some Oracle compatibility, as oci sql scripts do not exist in Jelix. Also updated the dao to take into account tat '' equals NULL in Oracle.

@laurentj
Jelix member

If '' is equals to Null, why add the isnull condition ? We should add tests to verify that it does not break something in jacl2db. See jacl2.main_api.. and others jacl2.. tests

@kissifrot

Because when you insert '' it equals inserting null for Oracle, hence the added conditions. But when selecting '', Oracle won't convert it to null automatically, and so won't find anything.
Tested also on MySQL, it doesn't break jacl2db.

@laurentj laurentj merged commit 11d63d7 into jelix:jelix-1.3.x Mar 21, 2012
@laurentj
Jelix member

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.