Add some Oracle compatibility #43

Merged
merged 3 commits into from Mar 21, 2012

Conversation

Projects
None yet
2 participants
@kissifrot

This adds some Oracle compatibility, as oci sql scripts do not exist in Jelix. Also updated the dao to take into account tat '' equals NULL in Oracle.

@laurentj

This comment has been minimized.

Show comment
Hide comment
@laurentj

laurentj Mar 20, 2012

Member

If '' is equals to Null, why add the isnull condition ? We should add tests to verify that it does not break something in jacl2db. See jacl2.main_api.. and others jacl2.. tests

Member

laurentj commented Mar 20, 2012

If '' is equals to Null, why add the isnull condition ? We should add tests to verify that it does not break something in jacl2db. See jacl2.main_api.. and others jacl2.. tests

@kissifrot

This comment has been minimized.

Show comment
Hide comment
@kissifrot

kissifrot Mar 20, 2012

Because when you insert '' it equals inserting null for Oracle, hence the added conditions. But when selecting '', Oracle won't convert it to null automatically, and so won't find anything.
Tested also on MySQL, it doesn't break jacl2db.

Because when you insert '' it equals inserting null for Oracle, hence the added conditions. But when selecting '', Oracle won't convert it to null automatically, and so won't find anything.
Tested also on MySQL, it doesn't break jacl2db.

laurentj added a commit that referenced this pull request Mar 21, 2012

Merge pull request #43 from kissifrot/6d8fc1bcb4841768150e81e7ce00418…
…fbf650f35

jAcl2Db and jAuthdb: fixed some Oracle compatibilities

@laurentj laurentj merged commit 11d63d7 into jelix:jelix-1.3.x Mar 21, 2012

@laurentj

This comment has been minimized.

Show comment
Hide comment
@laurentj

laurentj Mar 21, 2012

Member

ok thanks

Member

laurentj commented Mar 21, 2012

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment