Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

removing some calls that were manual and doing them all in the foreach

  • Loading branch information...
commit 8f8e91f388494b0f34c8a30fad6bc842b806a905 1 parent a8ce06a
@dogmatic69 dogmatic69 authored
Showing with 13 additions and 5 deletions.
  1. +13 −5 core/installer/tests/cases/libs/installer.test.php
View
18 core/installer/tests/cases/libs/installer.test.php
@@ -113,20 +113,28 @@ public function testInstaller() {
'5' => 'sessions',
);
$this->assertEqual($expected, $this->db->listSources());
- $this->assertTrue($Installer->installPlugin($Version, $Installer->cleanConnectionDetails(array('connection' => $this->db->config)), 'Configs'));
- $this->assertTrue($Installer->installPlugin($Version, $Installer->cleanConnectionDetails(array('connection' => $this->db->config)), 'Themes'));
- $this->assertTrue($Installer->installPlugin($Version, $Installer->cleanConnectionDetails(array('connection' => $this->db->config)), 'Routes'));
$pluginsToInstall = App::objects('plugin');
natsort($pluginsToInstall);
foreach($pluginsToInstall as $k => $pluginToInstall) {
- if(in_array($pluginToInstall, array('Management', 'Migrations', 'Configs', 'Themes', 'Routes'))) {
+ if(in_array($pluginToInstall, array('Migrations'))) {
continue;
}
- $this->assertTrue($Installer->installPlugin($Version, $Installer->cleanConnectionDetails(array('connection' => $this->db->config)), $pluginToInstall), sprintf('%s could not be installed', $pluginToInstall));
+
+ $this->assertTrue(
+ $Installer->installPlugin($Version, $connectionDetails, $pluginToInstall),
+ sprintf('%s could not be installed', $pluginToInstall)
+ );
+ }
+
+ foreach($pluginsToInstall as $pluginToInstall) {
+ $this->__checkVersionCount($pluginToInstall);
}
}
+ /**
+ * @brief drop all tables for testing the installer
+ */
private function __cleanSystem($all = true) {
if(!isset($this->__oldTables)) {
$this->__oldTables = $this->db->listSources();
Please sign in to comment.
Something went wrong with that request. Please try again.