chore: replace use of deprecated methods #293
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the use of deprecated methods to what is recommended. Before these fixes, JellyCon was causing 20,000+ logs per day for deprecation.
Most changes relate to the following objects:
We're now setting properties through
InfoTagVideoinstead. This uses specific getters/settings and has stricter typing.For example,
setCastrequires a list ofxbmc.Actor. And some rating related settings require anint, not afloat.User Facing Changes
Notes
This does not replace every single use of a deprecated method yet. It handles the major offenders that were creating thousands of log entries, and some easy fixes. Over time, we can hopefully address the rest of the smaller ones.
The only ones left are due to
ListItem.setInfo()calls which should be usingInfoTagVideo,InfoTagMusic,InfoTagGame, orInfoTagPicture.