Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace use of deprecated methods #293

Closed
wants to merge 1 commit into from

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Jul 22, 2023

Updates the use of deprecated methods to what is recommended. Before these fixes, JellyCon was causing 20,000+ logs per day for deprecation.

Most changes relate to the following objects:

We're now setting properties through InfoTagVideo instead. This uses specific getters/settings and has stricter typing.

For example, setCast requires a list of xbmc.Actor. And some rating related settings require an int, not a float.

User Facing Changes

  • Kodi now accepts a list for more details like Studios and Countries.
    • When viewing info for a movie or show, we can see all of them, not just 1.

Notes

This does not replace every single use of a deprecated method yet. It handles the major offenders that were creating thousands of log entries, and some easy fixes. Over time, we can hopefully address the rest of the smaller ones.

The only ones left are due to ListItem.setInfo() calls which should be using InfoTagVideo, InfoTagMusic, InfoTagGame, or InfoTagPicture.

@SethFalco SethFalco marked this pull request as draft July 22, 2023 23:18
@SethFalco SethFalco force-pushed the chore/deprecations branch 3 times, most recently from f120809 to 3a1c406 Compare July 23, 2023 10:34
@SethFalco SethFalco marked this pull request as ready for review July 23, 2023 10:38
@SethFalco SethFalco force-pushed the chore/deprecations branch 6 times, most recently from 631ff75 to 5d65eaa Compare July 23, 2023 12:13
@SethFalco SethFalco force-pushed the chore/deprecations branch from 5d65eaa to 4953a95 Compare July 30, 2023 22:26
@oddstr13
Copy link
Member

We are making an effort in supporting current and previous release of Kodi, have you verified that these changes still work in Kodi 19?

@SethFalco
Copy link
Contributor Author

Sorry for being slow to respond. I've been very busy lately, but expect to have time to install and test on Kodi v19 this weekend. Prior to your comment, I'd only tested against Kodi v20.

Perhaps if it's not documented already, in CONTRIBUTING.md we can note that contributions must support the last 2 stable releases of Kodi.

I did read the Kodi documentation already, and am wary some if not all of these changes are incompatible with Kodi v19, in which case I'll close the PR.

However, I'd still like to test manually as I can see InfoTagVideo was favored since Kodi v20, but it's not clear to me if it was only introduced in Kodi v20.

@SethFalco
Copy link
Contributor Author

Indeed, I've confirmed every single change introduced in this PR is incompatible with Kodi 19. 🪦
I'll close this for now, and can return to it when Kodi 21 is released.

Meanwhile, I'll pull out the chores (adding venv to .gitignore) to a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants