Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto bitrate issues #1010

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Jul 8, 2021

Changes

  • Use detectBitrate function from the SDK to calculcate the "auto bitrate"
    • The function gives better results as the old apiclient did but the results are still low because the server API has a low limit making it hard to test the bitrates
  • Set default value for max bitrate to 100 (Mbit/s) instead of 0 (auto)
  • Use bitrate settings for music playback

Issues

Fixes #736

@crobibero
Copy link
Member

If the server endpoint is the limiting factor on upload size we can just change the limit for that endpoint

@nielsvanvelzen
Copy link
Member Author

I think increasing the limit should allow for better measurements as right now it maxes out at 10mb: (https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Api/Controllers/MediaInfoController.cs#L314)

While large media can easily use 20mbps

@thornbill thornbill merged commit 51f7e54 into jellyfin:master Jul 13, 2021
@nielsvanvelzen nielsvanvelzen deleted the auto-bitrate branch July 13, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max bitrate= auto not working in Fire stick tv
3 participants