Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd home sections #210
Add home sections #210
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks for the PR! The code is certainly a bit of a mess structurally. We’ve been trying to clean it up some as we go, but it’s a slow process. Just a heads up it may be a few days before this gets reviewed. |
b77746c
to
2fa75dd
This comment has been minimized.
This comment has been minimized.
I rebased the branch as there were some conflicts in strings.xml. |
This comment has been minimized.
This comment has been minimized.
I realized that the "latest additions" row is really annoying when all media types are showing. I also noticed that the feature of the web-home screen where you can select which (video-) libraries show in a single row doesn't work in my version. This change should probably not be merged unless some more features are added, I'm not sure if I have time in the next few weeks to implement this as I expect it requires quite a lot of changes in the code to add this without using hacks to get it working. |
This comment has been minimized.
This comment has been minimized.
@nielsvanvelzen I noticed a few minor issues in my testing also.
If you don't mind, I may continue your work here as this is a really nice feature! I should have some availability this week to work on it. |
This comment has been minimized.
This comment has been minimized.
I don't mind! I assume you have more knowledge about the code base than me, I'm curious how you would add the missing features. |
nielsvanvelzen commentedNov 25, 2019
I'm currently working on moving my personal library from Plex to Jellyfin and one of the things that annoyed me is that the sections I made in the web version weren't available in the TV app. So I implemented it!
I tried to make it look exactly the same as the web version but some things are still different:
It took quite some time to get familiar with this part of the code because I haven't used Java in a few years (I use Kotlin primarily) and the structure of the app doesn't make a lot of sense to me because there is strong cohesion between most classes.