Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ExoPlayer 2 #244

Merged
merged 7 commits into from Jan 8, 2020
Merged

Upgrade to ExoPlayer 2 #244

merged 7 commits into from Jan 8, 2020

Conversation

@nielsvanvelzen
Copy link
Member

nielsvanvelzen commented Jan 1, 2020

The goal of this PR is to upgrade ExoPlayer to the latest revision supported by the Amazon port, which is currently 2.10.6. In addition ExoMedia will be removed.

The goal is not to refactor the player code. Everything should work as it did before with minimal changes. In the future we should consider rebuilding all player code however.

Current progress:

  • Audio playback kinda works, progression is not tracked properly
  • Video playback works quite well with some minor issues
@nielsvanvelzen nielsvanvelzen changed the title Exoplayer 2 Upgrade to ExoPlayer 2 Jan 1, 2020
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review Jan 2, 2020
@nielsvanvelzen

This comment has been minimized.

Copy link
Member Author

nielsvanvelzen commented Jan 2, 2020

Everything seems to work fine for me, tested it on my television while actually watching series (instead of checking if things work in the emulator) and everything worked flawlessly.

Video quality is much better and smoother, upscaling is a lot nicer (which was the main reason for me to try upgrading).

For the reviewer(s): Playback for both video and audio changed. So both should be tested thoroughly, I'm mostly concerned about events (playback ending and play/pause) working differently than before.

@Florianisme

This comment has been minimized.

Copy link
Contributor

Florianisme commented Jan 2, 2020

Will test this evening on my TV!

@Florianisme

This comment has been minimized.

Copy link
Contributor

Florianisme commented Jan 2, 2020

Worked flawlessly! Butter smooth (at 4k) and no issues with the audio (5.1). Resuming after stopping worked aswell

@thornbill

This comment has been minimized.

Copy link
Member

thornbill commented Jan 3, 2020

This may be a good time to try killing the Google/Amazon build variants. The Amazon build of ExoPlayer should work for both and would drastically reduce build times.

Uses the amazon fork for exoplayer for all builds. This removes the need for a separate flavor for google/amazon devices 🎉
@nielsvanvelzen

This comment has been minimized.

Copy link
Member Author

nielsvanvelzen commented Jan 3, 2020

Increasing build times is always a good thing! Hopefully everything works as expected

@anthonylavado anthonylavado requested a review from thornbill Jan 3, 2020
Copy link
Member

anthonylavado left a comment

Looks good to me, testing will still be required.

A note to @joshuaboniface - we’ll need to modify our build steps to only make the single variant then.

@thornbill

This comment has been minimized.

Copy link
Member

thornbill commented Jan 3, 2020

I'm doing some testing on my assortment of Fire TV devices, so far so good! 🎉

@thornbill thornbill merged commit bf79e8c into jellyfin:master Jan 8, 2020
1 check passed
1 check passed
Jellyfin Android TV CI Build #20200104.1 succeeded
Details
@nielsvanvelzen nielsvanvelzen deleted the nielsvanvelzen:exoplayer2 branch Jan 9, 2020
@nielsvanvelzen nielsvanvelzen added this to In progress in v0.11.0 via automation Jan 28, 2020
@nielsvanvelzen nielsvanvelzen moved this from In progress to Done in v0.11.0 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v0.11.0
  
Done
4 participants
You can’t perform that action at this time.