Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PGS subtitles in ExoPlayer #2690

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Enable PGS subtitles in ExoPlayer #2690

merged 1 commit into from
Apr 22, 2023

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Apr 22, 2023 •
edited
Loading

ExoPlayer doesn't mention it in their documentation but they have an implementation for PGSSUB: https://github.com/google/ExoPlayer/blob/release-v2/library/core/src/main/java/com/google/android/exoplayer2/text/SubtitleDecoderFactory.java#L119-L120

Changes

  • Enable PGS subtitles in ExoPlayer

Issues

Fixes #2614
Fixes #2026

@nielsvanvelzen nielsvanvelzen added enhancement New feature or request playback Issue related to media playback backportable Change may be backported to a point release (remove label once cherrypicked) labels Apr 22, 2023
@nielsvanvelzen nielsvanvelzen mentioned this pull request Apr 22, 2023
Merged
@nielsvanvelzen nielsvanvelzen mentioned this pull request Apr 22, 2023
Merged
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Apr 22, 2023
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review April 22, 2023 14:04
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.16.0, v0.15.7 Apr 22, 2023
@nielsvanvelzen nielsvanvelzen merged commit d63ac02 into jellyfin:master Apr 22, 2023
@nielsvanvelzen nielsvanvelzen deleted the exo-pgs branch April 23, 2023 08:54
@nielsvanvelzen nielsvanvelzen mentioned this pull request Apr 23, 2023
Merged
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Apr 23, 2023
@mikewesten
Copy link

Are there plans to support vobsub (sub/idx) without the need for transcoding as well?

@branches78
Copy link

branches78 commented Apr 24, 2023 •
edited
Loading

Are there plans to support vobsub (sub/idx) without the need for transcoding as well?

I wonder the same, I just uploaded a log at ticket #2614 because i'm getting playback errors with VobSub, not transcoding.

@nielsvanvelzen
Copy link
Member Author

It doesn't look like vobsub is supported by ExoPlayer but please open an issue so we don't forget the demand.

@mikewesten
Copy link

It doesn't look like vobsub is supported by ExoPlayer but please open an issue so we don't forget the demand.

Okay, I'll make a feature request here.

@mikewesten mikewesten mentioned this pull request Apr 24, 2023
Open
@nielsvanvelzen nielsvanvelzen mentioned this pull request May 13, 2023
Merged
@silentTeee silentTeee mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request playback Issue related to media playback
Projects
None yet
Milestone
v0.15.7
Development

Successfully merging this pull request may close these issues.

Video transcodes with PGS subtitles Subtitles crash playback
4 participants
@nielsvanvelzen @mikewesten @branches78 @crobibero