Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if video has no audio stream #1671

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Fix crash if video has no audio stream #1671

merged 2 commits into from
Jan 27, 2024

Conversation

1hitsong
Copy link
Member

Changes

Checks if audio mediastream is valid before attempting to use language property.

Issues

Fixes #1670

@1hitsong 1hitsong added the bug-fix This fixes a bug. label Jan 27, 2024
@1hitsong 1hitsong requested a review from a team as a code owner January 27, 2024 00:50
@1hitsong 1hitsong changed the base branch from master to 2.0.z January 27, 2024 00:50
Copy link
Contributor

@jimdogx jimdogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a video that had no audio (crashes on the released build).

@1hitsong 1hitsong merged commit 20d2583 into jellyfin:2.0.z Jan 27, 2024
11 checks passed
@1hitsong 1hitsong deleted the fixNoAudioStreamCrash branch January 27, 2024 17:07
@1hitsong 1hitsong changed the title Fix no audio stream crash Fix crash if video has no audio stream Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

Client crashes when playing video with no audio track
2 participants