Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LaunchAgent for start at login on macOS 12 & fix image dpi #79

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Nov 21, 2024

Main changes:

  • Now it will detect the folder it runs from and will refuse to start when not being put into the Applications folder, as that may lead to various problems
  • Bumped the package version to let the macOS system register this specific package to resolve potential conflicts on launch at login, as older versions can still run at arbitrary locations and macOS could start a random one if they have the exact same package version.
  • The old mechanism we used for start at login no longer works on macOS 12 and the macOS 12 system API is awful to use. I tried multiple times with the LaunchAtLogin module we are using, and I cannot make it reliably to restart on login in a macOS 12 VM. Instead, I wrapped the LaunchAtLogin model to implement launch at login with custom LaunchAgents. This approach will not be compatible with sandboxing, but the jellyfin server itself is not compatible with sandboxing either, so there is no need to be concerned.
  • Provided scaled logo banner for different DPI monitors to fix the awful scaling on low DPI monitors:

Before:

image

Now:

image

Fixes #39

Fixes https://forum.jellyfin.org/t-démarrage-de-jellyfin-automatiquement-avec-le-mac

@anthonylavado anthonylavado self-requested a review November 26, 2024 08:14
@anthonylavado anthonylavado self-assigned this Nov 26, 2024
@anthonylavado anthonylavado merged commit 62c543f into jellyfin:master Dec 13, 2024
@gnattu gnattu deleted the fix-monterey-autostart branch December 13, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DMG Detection and Launch at Login
2 participants