Migrating backdropscreensaver, filterdialog and fetchhelper to ES6

[cromefire]

Changes
Migrating:

• src/components/backdropScreensaver/plugin.js
• src/components/filterdialog/filterdialog.js
• src/components/fetchhelper.js

Issues
Relates to: #868

[ferferga]

@cromefire I changed the title to a more descriptive one, so it's easier to sort among all the issues. Hope it's fine 😊.

[cromefire]

Well there was planned to be 3 more files in here if I find some time again

[ferferga]

@cromefire Feel free to change it once they are here. But, anyway, I would stick with adding the modules' names to the titles, all other PRs had it and it makes it easier to track. No worries if it's long (as long as GH doesn't break :P)

[cromefire]

Not really tested manually yet, if someone could either test it or tell me what to test

[cromefire]

I can't find much more errors, review pls

[heyhippari]

We have like 6 files called plugin.js, so I renamed it again to make it more clear :)

I can review and test it tonight.

[heyhippari]

Looks good after Dmitry's comments are addressed.

[cromefire]

Fixed
@MrTimscampi Please add the default dynamic import thing to the docs (in the epic)

[heyhippari]

@cromefire Done.

This is good to go as soon as @dmitrylyzo approves the changes :)

[dmitrylyzo]

OK

The only thing left is that paramsToString adds an empty string param to the URL. There was a check for an empty string. In fact, fetchHelper isn't used with "params", so this may probably be omitted.

Test code
at the end of fetchHelper.js

console.debug(paramsToString({
    a: 2,
    b: 0,
    c: true,
    d: false,
    e: '123',
    f: '',
    g: null,
    h: undefined
}));

Output

a=2&b=0&c=true&d=false&e=123&f=

f= - empty string param

[cromefire]

Will check for that too

[dkanada]

@cromefire if you merge develop we can merge this.

[cromefire]

So rebase on develop or what do you mean?

[cromefire]

Or just on master again?

[dkanada]

Oops I meant master.

[cromefire]

Done

[cromefire]

Hold this for a sec I can some errors testing it

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
5 Code Smells

No Coverage information
5.5% Duplication

[dmitrylyzo]

Not sure about SonarCloud "code smells"

[cromefire]

Okay forgot to pull, never mind...

Not sure about SonarCloud "code smells"

Yeah they smell... stuff. That function is explicitly written to do exactly why they "smell" (with the exception that I use a for (const loop, so it's definitely fine)

[cromefire]

And I don't think I can set them as ignored