Remove resource caching from service worker #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
nvv-drop-workbox
branch
from
3a72bba to
4c8903d
Compare
|
I've been wondering if there was really any point in this for awhile now... 😅 |
|
@nielsvanvelzen I noticed the serviceworker file wasn't being included in the build after these changes, I pushed up a change that should fix that if you want to confirm... |
|
Oops, I think it worked for me at first but perhaps I forgot to restart Webpack or something was cached. Can confirm the fix works on the deployed pages instance ✅:
|
This comment has been minimized.
This comment has been minimized.
nielsvanvelzen
force-pushed
the
nvv-drop-workbox
branch
from
b86a957 to
c55d7b6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Rebased to fix merge conflicts in package-lock file |
Cloudflare Pages deployment
|
thornbill
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ran into annoying cache issues from the worker occasionally and after thinking about it I came to the conclusion that it does not make any sense to cache the complete SPA.
Jellyfin web does not have offline functionality and the resources are served by the server. If the web client is used offline that means you can't connect to the server, so there is no point in caching it 🤷.
Changes
clientsClaimfunction from workbox (it really is just a one liner)Issues
Fixes #4549, fixes #4651