Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable network path field #5098

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Jan 12, 2024

Changes
Disables the network path configuration field

Issues
N/A

@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Jan 12, 2024
@thornbill thornbill added this to the v10.9.0 milestone Jan 12, 2024
@thornbill thornbill requested a review from a team as a code owner January 12, 2024 22:35
@thornbill thornbill changed the title Hide network path field Disable network path field Jan 13, 2024
Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit ade2010
Status ✅ Deployed!
Preview URL https://61d098de.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit f39ea2f into jellyfin:master Jan 16, 2024
22 checks passed
@thornbill thornbill deleted the hide-network-path branch January 16, 2024 21:53
@jasonmhite
Copy link

Sorry to resurrect an old MR, but I just noticed this change when I was messing with my libraries. I was relying on the network path because performance was a lot better through the Kodi addon and it helps Kodi pick up some other files the normal Jellyfin playback mode does not (like the files the intro skipper plugin generates), but I like having Jellyfin manage my metadata.

I'm having a hard time finding any context for why this feature is being hidden, is the intent to drop the ability to set a network path entirely long term? Or is this just pushing it out to a hidden setting in the XML? Just wanna know if I eventually need to find a workaround, since removing this breaks the native playback feature in the Kodi addon. Sorry if this is the wrong place to ask and thanks for your work on Jellyfin.

@PrplHaz4
Copy link
Contributor

PrplHaz4 commented Sep 5, 2024

Sorry to resurrect an old MR, but I just noticed this change when I was messing with my libraries. I was relying on the network path because performance was a lot better through the Kodi addon and it helps Kodi pick up some other files the normal Jellyfin playback mode does not (like the files the intro skipper plugin generates), but I like having Jellyfin manage my metadata.

I'm having a hard time finding any context for why this feature is being hidden, is the intent to drop the ability to set a network path entirely long term? Or is this just pushing it out to a hidden setting in the XML? Just wanna know if I eventually need to find a workaround, since removing this breaks the native playback feature in the Kodi addon. Sorry if this is the wrong place to ask and thanks for your work on Jellyfin.

More discussion on this is in the below PR. I believe the short of it is it's causing some challenges and proving hard to maintain as-is. Unfortunately, it's unlikely that re-adding the feature "properly" will ever get prioritized, and any integration using it would have to be updated to use the fix.

jellyfin/jellyfin#12446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants