Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: Failed to construct 'Headers': No matching constructor signature. #5558

Merged
merged 1 commit into from
May 19, 2024

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented May 19, 2024

Affected platforms:

  • Tizen 3
  • Tizen 4
  • webOS 4

Changes
Patch Headers to accept undefined.

Issues
Fixes jellyfin/jellyfin-tizen#260
Closes jellyfin/jellyfin-tizen#261

@dmitrylyzo dmitrylyzo added bug Something isn't working regression We broke something p: webos This PR or issue mainly concerns WebOS clients p: tizen This PR or issue mainly concerns Tizen clients labels May 19, 2024
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner May 19, 2024 19:38
@dmitrylyzo dmitrylyzo added this to In progress in Release 10.9.z via automation May 19, 2024
@dmitrylyzo dmitrylyzo added this to the v10.9.3 milestone May 19, 2024
Fixes `TypeError: Failed to construct 'Headers': No matching constructor signature.`
Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit ab70cc0
Status ✅ Deployed!
Preview URL https://718aaf07.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit a806eeb into jellyfin:release-10.9.z May 19, 2024
12 checks passed
Release 10.9.z automation moved this from In progress to Done May 19, 2024
@dmitrylyzo dmitrylyzo deleted the fix-headers branch May 19, 2024 20:48
@thornbill thornbill added the stable backport Backport into the next stable release label May 21, 2024
@Hansaplast
Copy link

+1 Tizen 3, Samsung UM83MU8000 TV, doesn't work ... 😞

@dmitrylyzo
Copy link
Contributor Author

+1 Tizen 3, Samsung UM83MU8000 TV, doesn't work ... 😞

Did you use the release-10.9.z branch of jellyfin-web (for app build)?

@Hansaplast
Copy link

Picked it up a prebuilt version https://github.com/jeppevinkel/jellyfin-tizen-builds (2024-05-20 16:47) said to include the fix.
Apologies if I should not have posted this here.

@dmitrylyzo
Copy link
Contributor Author

Picked it up a prebuilt version https://github.com/jeppevinkel/jellyfin-tizen-builds (2024-05-20 16:47) said to include the fix.

Hm, I tested this PR on my Tizen 4 TV and in the Tizen 3 emulator (+ webOS 4 emulator) and it worked.
My only guess is that perhaps the app was not updated due to some error. 🤷

@Hansaplast
Copy link

No worries - just thought I'd mention it. Super grateful that you guys work on this!

I've tried a all [pre-bult] versions that were released this month, and all failed (tested regular and master version).
In the end I just reverted back to an older version that I had downloaded a few months ago (2023-11-29).

Not: That old version works just fine after I just re-installed it (I always delete the application from my TV, before installing a new version). I did noticed that all versions that were released after that old version are around 10Mb in size, where as the old one is 45Mb in size ... not sure how relevant that could be though.

joshuaboniface pushed a commit that referenced this pull request May 25, 2024
Fix `TypeError: Failed to construct 'Headers': No matching constructor signature.`

Original-merge: a806eeb

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients p: webos This PR or issue mainly concerns WebOS clients regression We broke something
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants