Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (11)
@grafixeyehero grafixeyehero Jul 15, 2024
this fix console Warning: Failed prop type: Invalid prop `children` supplied to `ForwardRef(TableCell)`, expected a ReactNode. ```suggestion {isPluginLoading || !pluginDetails?.version?.version ? ( <Skeleton /> ) : ( pluginDetails.version.version )} ```
Outdated
...plugins/components/PluginDetailsTable.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'useEffect' is defined but never used.** [@typescript-eslint/no-unused-vars](https://typescript-eslint.io/rules/no-unused-vars)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'setIsLoading' is assigned a value but never used.** [@typescript-eslint/no-unused-vars](https://typescript-eslint.io/rules/no-unused-vars)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'setPluginDetails' is assigned a value but never used.** [@typescript-eslint/no-unused-vars](https://typescript-eslint.io/rules/no-unused-vars)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'setPluginName' is assigned a value but never used.** [@typescript-eslint/no-unused-vars](https://typescript-eslint.io/rules/no-unused-vars)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'isLoading' is already defined.** [@typescript-eslint/no-redeclare](https://typescript-eslint.io/rules/no-redeclare)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'pluginName' is already defined.** [@typescript-eslint/no-redeclare](https://typescript-eslint.io/rules/no-redeclare)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@github-actions github-actions[bot] Jul 15, 2024
**'pluginDetails' is already defined.** [@typescript-eslint/no-redeclare](https://typescript-eslint.io/rules/no-redeclare)
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@grafixeyehero grafixeyehero Jul 14, 2024
```suggestion const pluginDetails = useMemo(() => { if (pluginId && !isPluginsLoading) { const pluginInfo = findBestPluginInfo(pluginId, plugins); let version; if (pluginInfo) { // Find the installed version const repoVersion = packageInfo?.versions?.find(v => v.version === pluginInfo.Version); version = repoVersion || { version: pluginInfo.Version, VersionNumber: pluginInfo.Version }; } else { // Use the latest version version = packageInfo?.versions?.[0]; } let imageUrl; if (pluginInfo?.HasImage) { imageUrl = api?.axiosInstance.getUri({ baseURL: api.basePath, url: `/Plugins/${pluginInfo.Id}/${pluginInfo.Version}/Image` }); } return { canUninstall: !!pluginInfo?.CanUninstall, description: pluginInfo?.Description || packageInfo?.description || packageInfo?.overview, id: pluginId, imageUrl: imageUrl || packageInfo?.imageUrl || undefined, isEnabled: (isEnabledOverride && pluginInfo?.Status === PluginStatus.Restart) ?? pluginInfo?.Status !== PluginStatus.Disabled, name: pluginName || pluginInfo?.Name || packageInfo?.name, owner: packageInfo?.owner, status: pluginInfo?.Status, configurationPage: findBestConfigurationPage(configurationPages || [], pluginId), version, versions: packageInfo?.versions || [] }; } }, [api?.axiosInstance, api?.basePath, configurationPages, isEnabledOverride, isPluginsLoading, packageInfo?.description, packageInfo?.imageUrl, packageInfo?.name, packageInfo?.overview, packageInfo?.owner, packageInfo?.versions, pluginId, pluginName, plugins]); ```
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@grafixeyehero grafixeyehero Jul 14, 2024
```suggestion const pluginName = searchParams.get('name') ?? undefined; ```
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx
@grafixeyehero grafixeyehero Jul 14, 2024
```suggestion const isLoading = isConfigurationPagesLoading || isPackageInfoLoading || isPluginsLoading; ```
Outdated
src/apps/dashboard/routes/plugins/plugin.tsx