Translation of stream language

[baka0815]

The language of streams is - as far as I can tell - not properly translated.

I have subtitle streams which are displayed as "Englisch" (correct translation of en/eng/English) and some which are displayed as "Ger" which should be "Deutsch" (German).

Trying to find the source I found this line:

jellyfin/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs

Line 716 in 0bc142d

stream.Language = GetDictionaryValue(streamInfo.Tags, "language");

Is the translation missing or am I looking at the wrong place?

[baka0815]

I'm willing to look into this myself, however I would need some direction.

[IceStormNG]

I found the actual problem. The issue here:

jellyfin/MediaBrowser.Model/Entities/MediaStream.cs

Lines 374 to 379 in 0bc142d

	// Get full language string i.e. eng -> English. Will not work for some languages which use ISO 639-2/B instead of /T codes.
	string fullLanguage = CultureInfo
	.GetCultures(CultureTypes.NeutralCultures)
	.FirstOrDefault(r => r.ThreeLetterISOLanguageName.Equals(Language, StringComparison.OrdinalIgnoreCase))
	?.DisplayName;
	attributes.Add(StringHelper.FirstToUpper(fullLanguage ?? Language));

The official three letter code for German is "DEU" but jellyfin uses "Ger" sometimes (or receives that from ffmpeg), therefore, the CultureInfo of .Net will not translate it.

There might be a lookup table needed for the few codes that do not match properly.

If add something like this for debug purpose there before the listed lines.

if (Language.Equals("ger", StringComparison.OrdinalIgnoreCase))
{
     Language = "deu";
}

The subtitle (in this case) shows up properly as "German" in Jellyfin Web.

Though, I wouldn't hardcode the values here, but create some LUT to translate such values. There might be other country codes that are affected by this. But I also noticed the issue with German Subtitles, especially when external MKS files.

[baka0815]

This seems to be the problem described in the comment in your code snippet:
// Get full language string i.e. eng -> English. Will not work for some languages which use ISO 639-2/B instead of /T codes.

According to Wikipedia (https://de.wikipedia.org/wiki/Liste_der_ISO-639-2-Codes) ger is from the /B list.

So we might create a dictionary containing the /B from /T-mapping?

If the above is correct some more languages could be (incomplete):

alb / sqi (Albanian)
ces / cze (Czech)
chi / zho (Chinese)
fra / fre (French)

[IceStormNG]

Yes. And then is the question, do we translate it here for the display name, or do we translate the values already in the line which you noted, where the language is read from the files.

[baka0815]

I tried building jellyfin locally to try changing the behaviour, but I couldn't build it.

I cloned https://github.com/jellyfin/jellyfin-build and tried the instructions from the readme but the only thing I could build successfully was jellyfin-ffmpeg. Trying to build the server I got "missing build.yaml" errors. Also trying to use build.yaml.server.sample as a build.yaml file in the server/jellyfin directory just threw missing files (the ones listed in the yaml-file under packages. Any help in build jellyfin (Debian) would be appreciated.
PS.: Trying https://github.com/jellyfin/jellyfin-packaging/ didn't work either.

[nielsvanvelzen]

If you just need to build the server you can use the dotnet CLI, just run dotnet build / dotnet publish to build the code. An IDE like Rider/Visual Studio (code) also supports building the server.