Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[Docker] Default ffmpeg path is not being displayed #478
Question for UI devs please. Is it possible to write directly into field txtEncoderPath (src/encodingsettings.html, src/scripts/encodingssettings.js) from a method in class MediaEncoder? If so, how please?
I've worked on improving the FFmpeg path discovery and this is the final missing link to resolving this issue. I need to update that input textbox without writing to the config/encoding.xml file. Then we can display the FQPN to the encoder but it wouldn't be remember for next start (unless user clicks save! of course)..
So writing directly to .txtEncoderPath is a no go, and probably the wrong approach anyway.
What we can do is always write the current FFmpeg path to the xml so it is displayed to the user. That will fix this issue but presents another.. On restart, if CLI switch --ffmpeg is given, or for whatever reason the Custom path becomes unavailable, then the users Custom path in xml would be lost and over-written with a System $PATH. Not ideal, but is solved by creating a new entry in the xml specifically to record the Custom user entered setting. We therefore need two entries in the xml: 1) only gets set from the Transcode page (via user update/submit), 2) String to reflect the current path to FFmpeg being used.
I've put a change-set together and shall raise a PR soon for people to review.