Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Default ffmpeg path is not being displayed #478

Closed
LeoVerto opened this issue Jan 7, 2019 · 10 comments

Comments

@LeoVerto
Copy link
Member

commented Jan 7, 2019

When starting jellyfin from docker with an empty config dir the ffmpeg binary path is empty whereas it should default to /usr/bin/ffmpeg.

@sparky8251

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

Correct me if I'm wrong but this is just a display bug yes? FFMPEG has worked for me despite that box being empty before.

If so, it might be fixed by #412 and it definitely belongs as part of #122.

@cvium

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Where is it shown? If it's Settings -> Transcoding, then it is not fixed by #412. I'm not even sure it's a bug.

@louisefindlay23

This comment has been minimized.

Copy link

commented Jan 13, 2019

It makes transcoding fail for me until I set it.

@louisefindlay23 louisefindlay23 referenced this issue Jan 13, 2019
Closed
@sparky8251

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

That's new... Got logs of it failing? Might have to look in docker logs as well as the normal Jellyfin logs.

@louisefindlay23

This comment has been minimized.

Copy link

commented Jan 13, 2019

This is the docker logs - not sure where jellyfin logs are -

log.txt

@hawken93

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

For next time, this would be easier to read if attached as a file:)

@nvllsvm

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

Changed a comment to have the log in an attachment.

@LeoVerto LeoVerto added the bug label Feb 6, 2019

@LeoVerto LeoVerto changed the title [Docker] ffmpeg path not set by default [Docker] Default ffmpeg path is not being displayed Feb 6, 2019

@ploughpuff

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Question for UI devs please. Is it possible to write directly into field txtEncoderPath (src/encodingsettings.html, src/scripts/encodingssettings.js) from a method in class MediaEncoder? If so, how please?

I've worked on improving the FFmpeg path discovery and this is the final missing link to resolving this issue. I need to update that input textbox without writing to the config/encoding.xml file. Then we can display the FQPN to the encoder but it wouldn't be remember for next start (unless user clicks save! of course)..

@ploughpuff

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

So writing directly to .txtEncoderPath is a no go, and probably the wrong approach anyway.

What we can do is always write the current FFmpeg path to the xml so it is displayed to the user. That will fix this issue but presents another.. On restart, if CLI switch --ffmpeg is given, or for whatever reason the Custom path becomes unavailable, then the users Custom path in xml would be lost and over-written with a System $PATH. Not ideal, but is solved by creating a new entry in the xml specifically to record the Custom user entered setting. We therefore need two entries in the xml: 1) only gets set from the Transcode page (via user update/submit), 2) String to reflect the current path to FFmpeg being used.

I've put a change-set together and shall raise a PR soon for people to review.

@mkeguy106

This comment has been minimized.

Copy link

commented Feb 24, 2019

Fresh docker install today, first time jellyfin user. Videos wouldn't play. Had to set transcoding ffmpeg path in UI. Its also not located in /usr/bin, but in /usr/local/bin/ffmpeg. Once I set that playback worked just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.