Skip to content

Language code in subtitles problem with Chinese #6302

Open
@mhqschen

Description

Describe the bug
There are two problems related with the language code for Chinese.

  1. The language code in subtitles for Chinese can't be recognized.
    XXX.chi.srt, won't be recognized as "Chinese" but "Chi". While XXX.spa.srt will be successfully phased as "Spanish" and XXX.en.srt will be successfully phased as "English"
    And after tried several common language code for Chinese, I found chi, zh, zho, zh-hk will all be recognized as "Chi"
    On the other hand, ch, chn, chs, cht, cn, zh-cn, zh-cht are not able to be recognized but only shows them as subtitle name.

And this lead to the "Preferred subtitle language" setup not functional.

  1. There are 3 option in language choose dropdown for Chinese.
    "Chinese", "Chinese traditional" and "Chinese HongKong"
    When I used the upload subtitle function in browser. No matter what I option choose, the uploaded subtitles will all be renamed to XXX.chi.srt.

System (please complete the following information):

  • OS: [e.g. Debian, Windows]
  • Virtualization: Docker
  • Clients: Browser
  • Browser: Microsoft Edge 91 (chromium)
  • Jellyfin Version: 10.7.6

Expected behavior
Although Chinese has many branches, the most well known and used ones are "Chinese Simplified" and "Chinese Traditional".
They are used in most mutil-language scenarios and used by Netflix as well.
Better to change from "Chinese", "Chinese traditional" and "Chinese HongKong" to "Chinese Simplified" and "Chinese Traditional".

And hope to have a clear list of language code on wiki page instructing people how to rename their subtitles. And Jellyfin can be able to recognize "Chinese Simplified" and "Chinese Traditional".

If I can expect more, it would be wonderful to be able to fallback to other subtitles with "Chinese" in name when I choose "Preferred subtitle language" to"Chinese Simplified" but there isn't a subtitle in "Chinese Simplified" (same for "Chinese Traditional")

Server Logs
No error

FFmpeg Logs
No error

Browser Console Logs
No error

Screenshots
image
image
image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingconfirmedThis issue has been reviewed and confirmed

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions