fix: use Metal tonemap instead of OpenCL #11198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mark as draft until decisions are made about whether this will be included in 10.9. |
jellyfin-bot
added
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
gnattu
force-pushed
the
use-metal-tonemap
branch
from
e3cc4ce to
bc5dbfb
Compare
jellyfin-bot
removed
the
merge conflict
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
|
It's probably worth mentioning that |
gnattu
changed the title
nyanmisaka
approved these changes
Mar 23, 2024
crobibero
approved these changes
Mar 23, 2024
Bond-009
approved these changes
Mar 23, 2024
|
@gnattu You may also want to modify this string and their translations. (to OpenCL/CUDA/Metal or just GPGPU) https://github.com/jellyfin/jellyfin-web/blob/fa6981cb7fe1f1e976b0989363a54654df83d2f5/src/strings/en-us.json#L42 |
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As discussed in jellyfin/jellyfin-ffmpeg#357, the current OpenCL kernel runs extremely slow on Apple Silicon. This change updates the filter chain to use the Metal implementation of the tone map filter to handle Dolby Vision Profile 5 videos introduced by jellyfin/jellyfin-ffmpeg#369.
For Intel Macs, the OpenCL kernel is not compatible with certain GPUs and we will have the following error:
We need the Metal kernel to properly support Intel Macs.
Issues