Implement Device Cache to replace EFCoreSecondLevelCacheInterceptor #11901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnattu
force-pushed
the
remove-efcore-secondlevelcache
branch
from
a67810e to
c8754b8
Compare
cvium
reviewed
Jun 2, 2024
cvium
reviewed
Jun 2, 2024
|
Thats a fucking Awesome Pull Request I manually merged it into my Branch and my Server is Running since 25h without Issues, less Performance issues and MUCH MUCH less Memory. Always when the DB Lock kicked in, a chain reaction happened and Memory increased huge. Thank you |
crobibero
reviewed
Jun 27, 2024
crobibero
reviewed
Jul 1, 2024
crobibero
approved these changes
Jul 1, 2024
cvium
reviewed
Jul 1, 2024
Shadowghost
approved these changes
Jul 20, 2024
The EFCoreSecondLevelCacheInterceptor will place a huge lock even for reading. Implement a ConcurrentDictionary cache to replace it. Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
gnattu
force-pushed
the
remove-efcore-secondlevelcache
branch
from
bd87e04 to
7f12677
Compare
Signed-off-by: gnattu <gnattuoc@me.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
5 tasks
joshuaboniface
merged commit b7bc0e1
into
jellyfin:release-10.9.z
12 of 13 checks passed
|
This did miss 10.9.8 due to me not noticing it - sorry. It will land in 10.9.9, likely some time this week or next weekend. |
|
Is there something we can apply temporarily in the meantime? My server is suffering dramatically because of it currently. |
|
There's a workaround in the linked issue |
Apologies, must've missed that. Much obliged 😀 |
Closed
5 tasks
Bond-009
pushed a commit
that referenced
this pull request
Aug 5, 2024
Implement Device Cache to replace EFCoreSecondLevelCacheInterceptor Original-merge: b7bc0e1 Merged-by: joshuaboniface <joshua@boniface.me> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EFCoreSecondLevelCacheInterceptor will place a huge lock even for reading. Implement a ConcurrentDictionary cache to replace it.
Changes
Issues
Closes #11823