Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Australian PG rating #12043

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix the Australian PG rating #12043

merged 1 commit into from
Jun 20, 2024

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Jun 9, 2024

As per https://www.classification.gov.au/classification-ratings/what-are-ratings

Changes
Move PG to the top of the list for 15+

Issues
Fixes #11650

Well, sort of. I don't think it is possible to differentiate between them, as we'd be comparing the integer values, not the position in the list?

I also think it's not really appropriate for us to set it to a lower age either, as that'd be factually wrong.

@oddstr13 oddstr13 added the stable backport Backport into the next stable release label Jun 9, 2024
@gnattu
Copy link
Member

gnattu commented Jun 9, 2024

I'm fine with this as PG with 16 is incorrect anyway. However, this still leaves a problem for us because PG and M now behave the same as MA, but they actually have different meanings in Australian law.

For 10.9, I guess this is the best we can do. For 10.10, maybe we can extend the rating from int to float and use decimals to indicate different levels at the same age restriction. For example, PG in Australia could be 15.0, M could be 15.1, and MA could be 15.2. This way, we don't need to change all of the comparison logic, and Australian users can still set the children with a PG limit to block access to M and MA content.

Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all we can do for 10.9

@oddstr13 oddstr13 changed the base branch from master to release-10.9.z June 15, 2024 17:47
As per https://www.classification.gov.au/classification-ratings/what-are-ratings

Fixes #11650
Well, sort of. I don't think it is possible to differentiate between them, as we'd be comparing the integer values, not the position in the list?
@Bond-009 Bond-009 merged commit 1606b6c into release-10.9.z Jun 20, 2024
12 of 13 checks passed
@Bond-009 Bond-009 deleted the pr-parental-au-1 branch June 20, 2024 09:20
joshuaboniface pushed a commit that referenced this pull request Jun 23, 2024
Fix the Australian PG rating

Original-merge: 1606b6c

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jun 23, 2024
@Rygle
Copy link

Rygle commented Sep 7, 2024

Please see my comments here
#11650 (comment)

It should be that setting a profile to parental rating AU-PG will show U, G, AU-G, 7, and AU-PG, but not above.

AU-PG should incorporate only ratings that are clearly below it such as U, G, AU-G, 7, and AU-PG, but not ratings where there might be any ambiguity including PG, 13, 14, 15, or anything else that is open to interpretation. The onus is then on the parent to set the ratings in the metadata before something shows up. It is better to err toward caution rather than have a parental rating of AU-PG show AU-MA15+ rated material.

@Rygle
Copy link

Rygle commented Sep 7, 2024

This whole thing seems have gone wrong in an effort to make things more granular.

Perhaps a better approach would be to make things more granular in the options available in the settings rather than in the interpretation of the settings that the user has no control over (apart from re-compiling Jellyfin). So all profiles have a check list of all possible ratings, and the parent/administrator has to explicitly tick every rating they want to be visible. Or to speed this up, it could have umbrella categories with sub-categories that get selected if the umbrella category is selected, but only if the umbrella category is selected. Alternately, there could be a tick box for "more granular ratings selections" that does something like the following (if un-ticked it can remain as it was)...

So, in the Jellyfin settings, I will see something like;

NR [ ]
-- NR [ ]
-- AU-NC [ ]
etc for other countries

U [ ]
-- U [ ]
-- AU-U [ ]
etc for other countries

G [ ]
-- MPAA-G [ ]
-- AU-G [ ]
-- 7 [ ]
etc for other countries

PG [ ]
-- 13
-- PG-13 [ ]
-- AU-PG [ ]
-- 14 [ ]
etc for other countries

M [ ]
-- MPAA-M [ ]
-- 15 [ ]
-- AU-M [ ]
-- AU-MA15 [ ]
etc for other countries

etc, etc.

That way a parent/administrator can tick either the larger category that will select all under it, or just tick the ratings they want.

Additionally, if there are ratings/classifications that are not available in Jellyfin that match the metadata for your region/location, Jellyfin should allow the parent/administrator to type in their own custom ratings that match the metadata that their scraper is getting for their location, and that these get incorporated into the longer list of tick-boxes for ratings once entered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Australian Classification Ratings not correct
7 participants