Fix season handling ("Season Unknown" / unneccesary empty seasons) #12240
Conversation
nielsvanvelzen
changed the title
|
@sjorge please take a look |
|
@Shadowghost still havent figured out how to build jellyfin myself. I can certainly retest once thus hits the next release. |
|
Hi, I just tested this version, it works perfectly fine on my device, and the unneccesary empty seasons doesn't show anymore :) |
|
I deleted the NFO files and it caused an unknown season to appear. Now I can't delete these non-existent error messages. |
Fix season handling ("Season Unknown" / unneccesary empty seasons)
Original-merge: c1f7ccb
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
How did you manage to test it no longer appearing? I'm on the latest release which this seems to be included in and I don't see any indication of it being fixed. I still have blank seasons and specials, after refreshing metadata to make them disappear, then they re-appear on a library scan. EDIT: I've restarted the server since upgrading and tried again, seems to be working. I'll test further. |
|
@Shadowghost sadly #11575 is broken again, seasons are no longer created when 'Display specials within seasons they are aired' is unchecked. Exit: is it safe to downgrade? There are no new migrations in the .8 release right? |
|
Even worse, with the work around of enabling the option a lot of other weirdness is happening now. All shows that are completed, now show 1 empty blue dot indicator.
I'm just going to run the risk of a downgrade breaking everything and try and roll back. |
Hi @JamsRepos, I manually ran the branch
Great, I think it would be better to have more people test it :)
Hi @sjorge, not sure about that, give it a snapshot before you downgrade will be better maybe? |
|
@sjorge it's safe to downgrade, no database migrations in 10.9.8. We only had one in 10.9.4 |
|
Ok downgrade went fine, am traveling so was way harder to do than usual as I did not make a vm backup before upgrading. 10.9.8: regressed to #11575 behavior, but the workaround of having the option checked no longer works. the partial revert seems to have made worse to what we had pre-10.9.7. I did the testing by dropping a .ignore in a show folder, triggering 2 full rescans, removing the .ignore and triggering 1 full rescan. Additional 10.9.8 seems to now also have a new weird issue after a full rescan were it marked all series level entries a unwatched if it only contains virtual seasons that are watched. Maybe the entire previous PR should be reverted? I can live with the workaround until 19.10 release. So this can be properly addressed in master. Bit hard to provide full logs on my phone though. If need be I can make fresh ones in ~1 week when I get home. |
Broken ancestry would also explain the weird new unwatched status issue I think. Edit: I wonder if there is different behavior between series -> season -> episode ancestry when season level is: a) all virtual (me), b) all physical, c) mix of physical and virtual That could explain the different results. |
|
If I remember correctly from my debugging, ancestry is borked only for virtual seasons because those are created on-demand after scanning. In this case we need to recalculate the episode ancestors but that is somewhat broken. |
|
Even after the update, virtual seasons still exist. Scanning all the libraries and restarting the server both didn't help me. |
Same. I rescanned, restarted, rescanned. restarted. Windows 10 JF 10.9.8 I even did a couple series on their own. Anything special we need to do? I added a reply to the forum post. Not sure where people want to discuss this issue. https://forum.jellyfin.org/t-how-to-disable-empty-seasons-missing-episode-fetcher?pid=30445#pid30445 |
|
You need to scan your library and select replace all metadata to remove the virtual seasons from your library. |
Thanks for your response, but I don't want to replace all my metadata. After reading your response, I created a batch file that created "Specials" folders in the root of all my series folders, manually ran a scan for new and updated. That created an actual path to the folder in the system instead of it being virtual. Afterwards, I then reversed my batch script and deleted the "Specials" folders to get rid of them. Luckily, all my real specials were in "Season 00" folders so I could get away with this. Looks like the issue is resolved. As a side product of doing this, it appears a few library issues I was having has been solved as it picked up several items it should have had in the library but for whatever reason, weren't there. |
Hey, sadly this didn't fix the virutal seasons for me. I'm trying to fix this, but they re-appear everytime. I tried full replace, deleting images, restarting, everything. Any ideas? Edit: nvm I fixed it. It was the NFO file in each folder :/ sadly it didn't get deleted when rescanning. So I guess I have to do it manually. Edit2: aaaand they are back, magically. Idk. I guess I give up. Edit3: Can confirm that the issue is fixed after fully deleting a series and rebuilding it. But this will be an absolute PITA. |
|
Is there any other solution? I don't want to receive the metadata again because I have modified it. |
|
Probably wait until the ancestry is properly fixed, I would expect a normal scan to then notice there is a virtual season with no episodes and removes it. |
|
So I tried everything and this is definitely not fixed fully, sadly. Future seasons for example will show up, when sonarr has them too. I deactivated everything I could, but there is just nothing else left to do. Even rebuilding series fully isn't working. The empty seasons will reappear eventually. Guess we have to wait. Don't waste ~18h trying to fix it, like I did. Not worth it. |
|
i can only add that the issue persists - but haven't completely rebuilt my library, as i would like to avoid that work the question i have is: is there actually still an issue (and was it acknowledged by the dev team?) or is the (lasting) solution to rebuild the library? |
|
There is still an issue with item ancestry.The original PR fixed it incompletely, the partial revert made it worse IMHO.~ sjorgeOn 24 Jul 2024, at 18:07, jotpunktopunkt ***@***.***> wrote:
i can only add that the issue persists - but haven't completely rebuilt my library, as i would like to avoid that work
the question i have is: is there actually still an issue (and was it acknowledged by the dev team?) or is the (lasting) solution to rebuild the library?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This PR reverted the part that made my set-up work again and it was then confirmed by multiple other users that it also fixed their problems. It's important to know that this change does not magically fix the extra seasons. You'll need to go to the individual series and use the "search for missing metadata" option (or replace all). It does not fix anything when doing a library scan. From the reports it's obvious there are still more issues to be solved. I'd ask everyone to please make a proper issue for that instead of commenting on this pull request. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Reverts a part of #12050.
Changes
Starting with 10.9.7, when refreshing metadata or scanning a series it would reset the virtual season to "Season Unknown". Reverting a part of the 10.9.7 related to season lookups fixed this.
Probably needs more testing for non-virtual season usages.Issues
Fixes #12208 (confirmed via forum)