Update XmlTvListingsProvider.cs to fix the record series button missing on many programs #12398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where certain programs like the "Good Morning America" no longer have the record series button.
Fix failing test.
|
Fixes issue #11976 |
|
For reference the xmltv.dtd is here https://github.com/XMLTV/xmltv/blob/master/xmltv.dtd . I am not sure if it really speaks about an isSeries boolean. Seems like it must be derived. |
Bond-009
approved these changes
Aug 8, 2024
Shadowghost
approved these changes
Aug 8, 2024
|
This probably should have targeted the 10.9.z branch. Otherwise, you'll have some grumpy guy commenting every week what's taking so long |
bpauquette
changed the title
theguymadmax can see into the future. How did he know? |
Bond-009
added a commit
to Bond-009/jellyfin
that referenced
this pull request
Aug 20, 2024
Update XmlTvListingsProvider.cs to fix the record series button missing on many programs
crobibero
pushed a commit
that referenced
this pull request
Aug 20, 2024
#12481) Co-authored-by: grumpycat <bryan.pauquette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where certain programs like the "Good Morning America" no longer have the record series button.
Changes
Assume that if the program has an EpisodeNumber then it is part of a series.
Issues
The record series button is not displaying on many programs that are generated by zaptoxml.pl perl script.
https://github.com/jef/zap2xml