Fix only returning one item from /Item/Latest api. #12492
+148
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit da313e5)
JPVenson
reviewed
Aug 24, 2024
| @@ -2592,6 +2592,106 @@ public List<BaseItem> GetItemList(InternalItemsQuery query) | |||
| return items; | |||
| } | |||
|
|
|||
| public List<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType) | |||
There was a problem hiding this comment.
Suggested change
| public List<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType) | |
| public IReadOnlyList<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType) |
| // Early exit if the distinct column is null | ||
| if (string.IsNullOrEmpty(distintColumn)) | ||
| { | ||
| return Enumerable.Empty<BaseItem>().ToList(); |
There was a problem hiding this comment.
Suggested change
| return Enumerable.Empty<BaseItem>().ToList(); | |
| return Array.Empty<BaseItem>(); |
The whole point of using the static method is to share the instance, a ToList does negate that advantage
| @@ -1339,6 +1339,21 @@ public List<BaseItem> GetItemList(InternalItemsQuery query, List<BaseItem> paren | |||
| return _itemRepository.GetItemList(query); | |||
| } | |||
|
|
|||
| public List<BaseItem> GetItemList(InternalItemsQuery query, List<BaseItem> parents, CollectionType collectionType) | |||
There was a problem hiding this comment.
Suggested change
| public List<BaseItem> GetItemList(InternalItemsQuery query, List<BaseItem> parents, CollectionType collectionType) | |
| public IReadOnlyList<BaseItem> GetItemList(InternalItemsQuery query, IEnumerable<BaseItem> parents, CollectionType collectionType) |
| /// <param name="parents">Items to use for query.</param> | ||
| /// <param name="collectionType">Collection Type.</param> | ||
| /// <returns>List of items.</returns> | ||
| List<BaseItem> GetItemList(InternalItemsQuery query, List<BaseItem> parents, CollectionType collectionType); |
There was a problem hiding this comment.
Suggested change
| List<BaseItem> GetItemList(InternalItemsQuery query, List<BaseItem> parents, CollectionType collectionType); | |
| IReadOnlyList<BaseItem> GetItemList(InternalItemsQuery query, IEnumerable<BaseItem> parents, CollectionType collectionType); |
| /// <param name="query">The query.</param> | ||
| /// <param name="collectionType">Collection Type.</param> | ||
| /// <returns>List<BaseItem>.</returns> | ||
| List<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType); |
There was a problem hiding this comment.
Suggested change
| List<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType); | |
| IReadOnlyList<BaseItem> GetLatestItemList(InternalItemsQuery query, CollectionType collectionType); |
JPVenson
reviewed
Aug 24, 2024
| } | ||
| } | ||
|
|
||
| return items; |
There was a problem hiding this comment.
Suggested change
| return items; | |
| return items.ToReadOnlyArray(); |
JPVenson
approved these changes
Aug 24, 2024
|
@Bond-009 it would be good to know if this is on your radar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an extra function to the SqliteItemRepository to do a sub query to get the top N number of unique series/albums names sorted by datecreated. The min value of the datecreated from the subquery is then used to retrieve the rows for use for the /item/latest api.
Issues
Fixes #10993
Fixes #1880