Refactor library.db into jellyfin.db and EFCore #12798

JPVenson · 2024-10-09T17:20:44Z

Migrated all data from old library.db into new tables inside jellyfin.db.

Note:
All EFCore repositories make libraral use of the null-forgiving operator ! for navigation properties. This needs to be done as those are expressions that are never actually run client side but only interpreted for SQL query generation. But as the dotnet compiler cannot know that and we have strict nullables enabled it will complain otherwise. I am strictly against putting a note like this on each query therefor this is your warning.

Changes

Migrated all data into new schema
Refactored IItemRepository and extracted IPeopleRepository, IMediaStreamRepository, IUserDataRepository, IChapterRepository
Created new Table BaseItemProvider to expand the aggregate column of ItemProvider in TypedBaseItem
Added forginKeys where applicable
Removed the Score values from Search

ToDo's

Fix that one UnitTest failing
Refactor other aggregate keys in BaseItemEntity into their own tables
Add enums for BaseItemEntity instead of plain string values
Testing 🗿
Apply NonTrackedQuery hint where applicable
Merge Migrations

Issues
All of them

…serData

crobibero

fast-path initial review

Emby.Server.Implementations/Data/ItemTypeLookup.cs

MediaBrowser.Controller/Persistence/IItemTypeLookup.cs

Emby.Server.Implementations/Data/ItemTypeLookup.cs

MediaBrowser.Controller/Persistence/IItemTypeLookup.cs

Jellyfin.Server.Implementations/Item/MediaAttachmentRepository.cs

MediaBrowser.Controller/Persistence/IPeopleRepository.cs

Jellyfin.Data/Entities/UserData.cs

Jellyfin.Data/Entities/Chapter.cs

Jellyfin.Server.Implementations/Item/BaseItemRepository.cs

Co-authored-by: Cody Robibero <cody@robibe.ro>

github-actions · 2024-10-09T19:07:35Z

Changes in OpenAPI specification found. Expand to see details.

What's Changed

`GET` /Artists

Parameters:

Changed: sortBy in query

`GET` /Artists/AlbumArtists

Parameters:

Changed: sortBy in query

`GET` /Channels/{channelId}/Items

Parameters:

Changed: sortBy in query

`GET` /Genres

Parameters:

Changed: sortBy in query

`GET` /Items

Parameters:

Changed: sortBy in query

`GET` /Items/{itemId}/ThemeSongs

Parameters:

Changed: sortBy in query

`GET` /Items/{itemId}/ThemeVideos

Parameters:

Changed: sortBy in query

`GET` /LiveTv/Channels

Parameters:

Changed: sortBy in query

`GET` /LiveTv/Programs

Parameters:

Changed: sortBy in query

`POST` /LiveTv/Programs

Request:

Changed content type : application/json

Updated GetProgramsDto :

Changed property SortBy (array)

Gets or sets specify one or more sort orders, comma delimited. Options: Name, StartDate.

Changed items (string):
> These represent sort orders.

Removed enum values:
- SimilarityScore
- SearchScore
  Changed content type : text/json

Updated GetProgramsDto :

Changed property SortBy (array)

Gets or sets specify one or more sort orders, comma delimited. Options: Name, StartDate.

Changed items (string):
> These represent sort orders.

Removed enum values:
- SimilarityScore
- SearchScore
  Changed content type : application/*+json

Updated GetProgramsDto :

Changed property SortBy (array)

Gets or sets specify one or more sort orders, comma delimited. Options: Name, StartDate.

Changed items (string):
> These represent sort orders.

Removed enum values:
- SimilarityScore
- SearchScore

`GET` /MusicGenres

Parameters:

Changed: sortBy in query

`GET` /Trailers

Parameters:

Changed: sortBy in query

`GET` /Shows/{seriesId}/Episodes

Parameters:

Changed: sortBy in query

`GET` /Years

Parameters:

Changed: sortBy in query

`GET` /Items/{itemId}/ThemeMedia

Parameters:

Changed: sortBy in query

`DELETE` /Library/VirtualFolders

Return Type:

New response : 404 Not Found

jellyfin-bot · 2024-10-09T19:07:57Z

ABI Difference


Jellyfin.Data.dll
API compatibility errors between './abi-base/Jellyfin.Data.dll' (left) and './abi-head/Jellyfin.Data.dll' (right):
CP0002: Member 'Jellyfin.Data.Enums.ItemSortBy Jellyfin.Data.Enums.ItemSortBy.SimilarityScore' exists on ./abi-base/Jellyfin.Data.dll but not on ./abi-head/Jellyfin.Data.dll
CP0002: Member 'Jellyfin.Data.Enums.ItemSortBy Jellyfin.Data.Enums.ItemSortBy.SearchScore' exists on ./abi-base/Jellyfin.Data.dll but not on ./abi-head/Jellyfin.Data.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

MediaBrowser.Controller.dll
API compatibility errors between './abi-base/MediaBrowser.Controller.dll' (left) and './abi-head/MediaBrowser.Controller.dll' (right):
CP0001: Type 'MediaBrowser.Controller.Chapters.IChapterManager' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'string? MediaBrowser.Controller.Drawing.IImageProcessor.GetImageCacheTag(string, System.DateTime)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'string? MediaBrowser.Controller.Drawing.IImageProcessor.GetImageCacheTag(MediaBrowser.Model.Dto.BaseItemDto, MediaBrowser.Model.Entities.ChapterInfo)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'string MediaBrowser.Controller.Drawing.IImageProcessor.GetImageCacheTag(MediaBrowser.Model.Dto.BaseItemDto, MediaBrowser.Controller.Entities.ItemImageInfo)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Entities.BaseItem.GetMediaStreams()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Dto.MediaSourceInfo> MediaBrowser.Controller.Entities.BaseItem.GetMediaSources(bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'bool MediaBrowser.Controller.Entities.BaseItem.UpdateRatingToItems(System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem>)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.LoadChildren()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetCachedChildren()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetChildren(Jellyfin.Data.Entities.User, bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetChildren(Jellyfin.Data.Entities.User, bool, MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IEnumerable<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetRecursiveChildren(Jellyfin.Data.Entities.User, MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetRecursiveChildren()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetRecursiveChildren(bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetRecursiveChildren(System.Func<MediaBrowser.Controller.Entities.BaseItem, bool>)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Folder.GetRecursiveChildren(System.Func<MediaBrowser.Controller.Entities.BaseItem, bool>, bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IEnumerable<System.Tuple<MediaBrowser.Controller.Entities.LinkedChild, MediaBrowser.Controller.Entities.BaseItem>> MediaBrowser.Controller.Entities.Folder.GetLinkedChildrenInfos()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Genre.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Dto.MediaSourceInfo> MediaBrowser.Controller.Entities.IHasMediaSources.GetMediaSources(bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Entities.IHasMediaSources.GetMediaStreams()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Dto.MediaSourceInfo> MediaBrowser.Controller.Entities.IHasMediaSources.GetMediaSources(bool)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Entities.IHasMediaSources.GetMediaStreams()' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.IItemByName.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.IItemByName.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'MediaBrowser.Controller.Entities.BaseItem? MediaBrowser.Controller.Entities.InternalItemsQuery.SimilarTo.get' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Entities.InternalItemsQuery.SimilarTo.set' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'int MediaBrowser.Controller.Entities.InternalItemsQuery.MinSimilarityScore.get' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Entities.InternalItemsQuery.MinSimilarityScore.set' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Entities.PeopleHelper.AddPerson(System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo>, MediaBrowser.Controller.Entities.PersonInfo)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Person.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Studio.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Year.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Library.ILibraryManager.CreateItems(System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem>, MediaBrowser.Controller.Entities.BaseItem?, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Library.ILibraryManager.GetPeople(MediaBrowser.Controller.Entities.BaseItem)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Library.ILibraryManager.GetPeople(MediaBrowser.Controller.Entities.InternalPeopleQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.Person> MediaBrowser.Controller.Library.ILibraryManager.GetPeopleItems(MediaBrowser.Controller.Entities.InternalPeopleQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Threading.Tasks.Task MediaBrowser.Controller.Library.ILibraryManager.UpdatePeopleAsync(MediaBrowser.Controller.Entities.BaseItem, System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo>, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<System.Guid> MediaBrowser.Controller.Library.ILibraryManager.GetItemIds(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Library.ILibraryManager.GetPeopleNames(MediaBrowser.Controller.Entities.InternalPeopleQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery, bool)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery, System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem>)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'void MediaBrowser.Controller.Library.ILibraryManager.CreateOrUpdateItems(System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem>, MediaBrowser.Controller.Entities.BaseItem?, System.Threading.CancellationToken)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Library.ILibraryManager.GetPeople(MediaBrowser.Controller.Entities.BaseItem)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Library.ILibraryManager.GetPeople(MediaBrowser.Controller.Entities.InternalPeopleQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.Person> MediaBrowser.Controller.Library.ILibraryManager.GetPeopleItems(MediaBrowser.Controller.Entities.InternalPeopleQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Threading.Tasks.Task MediaBrowser.Controller.Library.ILibraryManager.UpdatePeopleAsync(MediaBrowser.Controller.Entities.BaseItem, System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.PersonInfo>, System.Threading.CancellationToken)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<System.Guid> MediaBrowser.Controller.Library.ILibraryManager.GetItemIds(MediaBrowser.Controller.Entities.InternalItemsQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<string> MediaBrowser.Controller.Library.ILibraryManager.GetPeopleNames(MediaBrowser.Controller.Entities.InternalPeopleQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery, bool)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.ILibraryManager.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery, System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem>)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaStreams(System.Guid)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaStreams(MediaBrowser.Controller.Persistence.MediaStreamQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaAttachment> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaAttachments(System.Guid)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaAttachment> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaAttachments(MediaBrowser.Controller.Persistence.MediaAttachmentQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Threading.Tasks.Task<System.Collections.Generic.List<MediaBrowser.Model.Dto.MediaSourceInfo>> MediaBrowser.Controller.Library.IMediaSourceManager.GetPlaybackMediaSources(MediaBrowser.Controller.Entities.BaseItem, Jellyfin.Data.Entities.User, bool, bool, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Dto.MediaSourceInfo> MediaBrowser.Controller.Library.IMediaSourceManager.GetStaticMediaSources(MediaBrowser.Controller.Entities.BaseItem, bool, Jellyfin.Data.Entities.User)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Threading.Tasks.Task<System.Collections.Generic.List<MediaBrowser.Model.Dto.MediaSourceInfo>> MediaBrowser.Controller.Library.IMediaSourceManager.GetRecordingStreamMediaSources(MediaBrowser.Controller.LiveTv.ActiveRecordingInfo, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaStreams(System.Guid)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaStreams(MediaBrowser.Controller.Persistence.MediaStreamQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaAttachment> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaAttachments(System.Guid)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaAttachment> MediaBrowser.Controller.Library.IMediaSourceManager.GetMediaAttachments(MediaBrowser.Controller.Persistence.MediaAttachmentQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Threading.Tasks.Task<System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Dto.MediaSourceInfo>> MediaBrowser.Controller.Library.IMediaSourceManager.GetPlaybackMediaSources(MediaBrowser.Controller.Entities.BaseItem, Jellyfin.Data.Entities.User, bool, bool, System.Threading.CancellationToken)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Dto.MediaSourceInfo> MediaBrowser.Controller.Library.IMediaSourceManager.GetStaticMediaSources(MediaBrowser.Controller.Entities.BaseItem, bool, Jellyfin.Data.Entities.User)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Threading.Tasks.Task<System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Dto.MediaSourceInfo>> MediaBrowser.Controller.Library.IMediaSourceManager.GetRecordingStreamMediaSources(MediaBrowser.Controller.LiveTv.ActiveRecordingInfo, System.Threading.CancellationToken)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromItem(MediaBrowser.Controller.Entities.BaseItem, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromArtist(MediaBrowser.Controller.Entities.Audio.MusicArtist, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromGenres(System.Collections.Generic.IEnumerable<string>, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromItem(MediaBrowser.Controller.Entities.BaseItem, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromArtist(MediaBrowser.Controller.Entities.Audio.MusicArtist, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Library.IMusicManager.GetInstantMixFromGenres(System.Collections.Generic.IEnumerable<string>, Jellyfin.Data.Entities.User?, MediaBrowser.Controller.Dto.DtoOptions)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.ChapterInfo> MediaBrowser.Controller.Persistence.IItemRepository.GetChapters(MediaBrowser.Controller.Entities.BaseItem)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'MediaBrowser.Model.Entities.ChapterInfo MediaBrowser.Controller.Persistence.IItemRepository.GetChapter(MediaBrowser.Controller.Entities.BaseItem, int)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Persistence.IItemRepository.SaveChapters(System.Guid, System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.ChapterInfo>)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaStream> MediaBrowser.Controller.Persistence.IItemRepository.GetMediaStreams(MediaBrowser.Controller.Persistence.MediaStreamQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Persistence.IItemRepository.SaveMediaStreams(System.Guid, System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaStream>, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Model.Entities.MediaAttachment> MediaBrowser.Controller.Persistence.IItemRepository.GetMediaAttachments(MediaBrowser.Controller.Persistence.MediaAttachmentQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Persistence.IItemRepository.SaveMediaAttachments(System.Guid, System.Collections.Generic.IReadOnlyList<MediaBrowser.Model.Entities.MediaAttachment>, System.Threading.CancellationToken)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<System.Guid> MediaBrowser.Controller.Persistence.IItemRepository.GetItemIdsList(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Persistence.IItemRepository.GetPeople(MediaBrowser.Controller.Entities.InternalPeopleQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'void MediaBrowser.Controller.Persistence.IItemRepository.UpdatePeople(System.Guid, System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo>)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Persistence.IItemRepository.GetPeopleNames(MediaBrowser.Controller.Entities.InternalPeopleQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Persistence.IItemRepository.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Persistence.IItemRepository.GetMusicGenreNames()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Persistence.IItemRepository.GetStudioNames()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Persistence.IItemRepository.GetGenreNames()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<string> MediaBrowser.Controller.Persistence.IItemRepository.GetAllArtistNames()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<System.Guid> MediaBrowser.Controller.Persistence.IItemRepository.GetItemIdsList(MediaBrowser.Controller.Entities.InternalItemsQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Persistence.IItemRepository.GetItemList(MediaBrowser.Controller.Entities.InternalItemsQuery)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<string> MediaBrowser.Controller.Persistence.IItemRepository.GetMusicGenreNames()' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<string> MediaBrowser.Controller.Persistence.IItemRepository.GetStudioNames()' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<string> MediaBrowser.Controller.Persistence.IItemRepository.GetGenreNames()' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0006: Cannot add interface member 'System.Collections.Generic.IReadOnlyList<string> MediaBrowser.Controller.Persistence.IItemRepository.GetAllArtistNames()' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
CP0001: Type 'MediaBrowser.Controller.Persistence.IUserDataRepository' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IEnumerable<System.Tuple<MediaBrowser.Controller.Entities.LinkedChild, MediaBrowser.Controller.Entities.BaseItem>> MediaBrowser.Controller.Playlists.Playlist.GetManageableItems()' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.PersonInfo> MediaBrowser.Controller.Providers.MetadataResult<T>.People.get' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Audio.MusicArtist.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.IList<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.Audio.MusicGenre.GetTaggedItems(MediaBrowser.Controller.Entities.InternalItemsQuery)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
CP0002: Member 'System.Collections.Generic.List<MediaBrowser.Controller.Entities.BaseItem> MediaBrowser.Controller.Entities.TV.Series.GetSeasons(Jellyfin.Data.Entities.User, MediaBrowser.Controller.Dto.DtoOptions)' exists on ./abi-base/MediaBrowser.Controller.dll but not on ./abi-head/MediaBrowser.Controller.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

MediaBrowser.Model.dll
API compatibility errors between './abi-base/MediaBrowser.Model.dll' (left) and './abi-head/MediaBrowser.Model.dll' (right):
CP0002: Member 'bool MediaBrowser.Model.Entities.MediaStream.IsHearingImpaired.get' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

…yfin into feature/EFUserData

jellyfin-bot · 2024-11-19T20:47:53Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

MediaBrowser.Controller/Persistence/IItemTypeLookup.cs

crobibero · 2024-11-13T14:38:19Z

Emby.Server.Implementations/ApplicationHost.cs

+            if (path is null)
+            {
+                return null;
+            }


Should probably throw if it is null instead

Path can be null for some items, this ensures its not throwing on that case.

Jellyfin.Server.Implementations/Item/BaseItemRepository.cs

joshuaboniface

From a purely functional perspective, this gets my LGTM. I've tested it with an import of my existing large library several times and it seems to cover all the bases and nothing major looks broken at this point. I have not reviewed the code itself however; I leave that to @jellyfin/server.

In terms of outstanding bugs, #13047 contains the one major one I've observed so far, but that can be fixed in a subsequent PR as it does not (I believe) affect the actual data migrations, as can any optimizations.

Bond-009

First half of a review

Jellyfin.Data/Entities/BaseItemEntity.cs

.editorconfig

Emby.Server.Implementations/Library/UserDataManager.cs

Jellyfin.Api/Controllers/PlaystateController.cs

Jellyfin.Api/Controllers/UserLibraryController.cs

Jellyfin.Data/Entities/People.cs

Jellyfin.Server.Implementations/Item/BaseItemRepository.cs

jellyfin-bot · 2024-12-14T10:20:47Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

JPVenson and others added 17 commits September 7, 2024 19:07

Migrated UserData from library sqlite db to jellyfin.db

d0b4b2d

WIP move baseitem to jellyfin.db

ee1bdf4

Merge remote-tracking branch 'jellyfinorigin/master' into feature/EFU…

d3a3d9f

…serData

WIP BaseItem search refactoring

6c819fe

WIP Search refactoring and Provider ID refactoring

d5409a2

WIP port search function

527998c

Removed SimilarityScore and ported Search function

9010316

Added Sorting and Grouping

ea81db6

WIP migration sqlite item repository to efcore

6acd146

Removed BaseSqliteRepository

15bf43e

Naming refactoring and WIP porting of new interface repositories

be48cdd

WIP porting new Repository structure

b09a41a

Ported new Item Repository architecture

2014fa5

Added BaseItem Configuration

3dc4024

Added EF BaseItem migration

c2844bd

Fixed (most) tests

01d834f

Add migration for library.db to jellyfin.db

5267851

crobibero reviewed Oct 9, 2024

View reviewed changes

JPVenson and others added 2 commits October 9, 2024 21:03

Apply suggestions from code review

473628b

Co-authored-by: Cody Robibero <cody@robibe.ro>

Merge branch 'jellyfin:master' into feature/EFUserData

f1ae764

JPVenson added 2 commits October 9, 2024 23:01

Expanded BaseItem aggregate types

eb601e9

Fixed AncestorIds and applied review comments

2955f2f

JPVenson added 3 commits November 16, 2024 22:10

Fixed search case sensitivity

b617736

Removed grouping key for testing

17e4485

Merge branch 'master' into feature/EFUserData

427359d

jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Nov 17, 2024

JPVenson added 6 commits November 17, 2024 11:03

Applied coding style

b395536

Fixed error

c71dc38

Merge branch 'feature/EFUserData' of https://github.com/JPVenson/jell…

68252ff

…yfin into feature/EFUserData

Merge remote-tracking branch 'origin/master' into feature/EFUserData

fa5faa0

Fixed ChapterRepository not set

25f8e22

Fixed server side distinct filter

136a799

jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Nov 19, 2024

Merge remote-tracking branch 'origin/master' into feature/EFUserData

0dd6dac

jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Nov 19, 2024

Updated usage of internal user Id

80cace4

crobibero reviewed Nov 23, 2024

View reviewed changes

JPVenson added 2 commits November 24, 2024 10:58

Applied review comments

6a08361

removed unused

3b18a36

joshuaboniface approved these changes Nov 28, 2024

View reviewed changes

joshuaboniface mentioned this pull request Nov 26, 2024

[Group] Jellyfin.db EFCore refactor bugs & issues #13047

Open

Bond-009 reviewed Nov 30, 2024

View reviewed changes

This comment was marked as off-topic.

Sign in to view

gnattu mentioned this pull request Dec 1, 2024

Episode multiple versions #8004

Open

Merge branch 'jellyfin:master' into feature/EFUserData

fe1aab0

gnattu mentioned this pull request Dec 10, 2024

Music (Songs) not added / parsed correctly into Albums #6694

Open

jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Dec 14, 2024

Merge remote-tracking branch 'origin/master' into feature/EFUserData

1c3196d

jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Dec 15, 2024

Applied review comments

a0c568b

Refactor library.db into jellyfin.db and EFCore #12798

Are you sure you want to change the base?

Refactor library.db into jellyfin.db and EFCore #12798

Conversation

JPVenson commented Oct 9, 2024 • edited Loading

crobibero left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2024 • edited Loading

What's Changed

GET /Artists

Parameters:

GET /Artists/AlbumArtists

Parameters:

GET /Channels/{channelId}/Items

Parameters:

GET /Genres

Parameters:

GET /Items

Parameters:

GET /Items/{itemId}/ThemeSongs

Parameters:

GET /Items/{itemId}/ThemeVideos

Parameters:

GET /LiveTv/Channels

Parameters:

GET /LiveTv/Programs

Parameters:

POST /LiveTv/Programs

Request:

GET /MusicGenres

Parameters:

GET /Trailers

Parameters:

GET /Shows/{seriesId}/Episodes

Parameters:

GET /Years

Parameters:

GET /Items/{itemId}/ThemeMedia

Parameters:

DELETE /Library/VirtualFolders

Return Type:

jellyfin-bot commented Oct 9, 2024 • edited Loading

jellyfin-bot commented Nov 19, 2024

crobibero Nov 13, 2024

Choose a reason for hiding this comment

JPVenson Nov 24, 2024

Choose a reason for hiding this comment

joshuaboniface left a comment • edited Loading

Choose a reason for hiding this comment

Bond-009 left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

jellyfin-bot commented Dec 14, 2024

JPVenson commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

`GET` /Artists

`GET` /Artists/AlbumArtists

`GET` /Channels/{channelId}/Items

`GET` /Genres

`GET` /Items

`GET` /Items/{itemId}/ThemeSongs

`GET` /Items/{itemId}/ThemeVideos

`GET` /LiveTv/Channels

`GET` /LiveTv/Programs

`POST` /LiveTv/Programs

`GET` /MusicGenres

`GET` /Trailers

`GET` /Shows/{seriesId}/Episodes

`GET` /Years

`GET` /Items/{itemId}/ThemeMedia

`DELETE` /Library/VirtualFolders

jellyfin-bot commented Oct 9, 2024 •

edited

Loading

joshuaboniface left a comment •

edited

Loading