Remove DynamicImageResponse local image after saved to metadata folder #12940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, local images provided by DynamicImageResponse were never cleaned up until the server was restarted. This issue has become more severe in 10.10, as the default is now set to use the system's native temp folder, which might be a RAM backed tmpfs. This behavior could lead to resource starvation for long-running servers performing multiple library scans. Metadata plugins prefer the old behavior should do its own backup.
Shadowghost
approved these changes
Nov 2, 2024
JPVenson
approved these changes
Nov 2, 2024
JPVenson
requested changes
Nov 2, 2024
JPVenson
approved these changes
Nov 2, 2024
cvium
reviewed
Nov 2, 2024
cvium
approved these changes
Nov 3, 2024
joshuaboniface
merged commit 3a9b48a
into
jellyfin:release-10.10.z
15 of 16 checks passed
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 3, 2024
Remove DynamicImageResponse local image after saved to metadata folder Original-merge: 3a9b48a Merged-by: joshuaboniface <joshua@boniface.me> Backported-by: Joshua M. Boniface <joshua@boniface.me>
5 tasks
gnattu
added a commit
to gnattu/jellyfin
that referenced
this pull request
Dec 1, 2024
Regression from jellyfin#12940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously, local images provided by DynamicImageResponse were never cleaned up until the server was restarted. This issue has become more severe in 10.10, as the default is now set to use the system's native temp folder, which might be a RAM backed tmpfs. This behavior could lead to resource starvation for long-running servers performing multiple library scans.
Metadata plugins prefer the old behavior should do its own backup.
Issues
Fixes #12937