Add Known Proxies to system configuration #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Sep 10, 2020
This was referenced Sep 10, 2020
|
I agree with your approach 100%, but i think MediaBrowser.Common.Extensions, HttpContextExtension.cs will have to be looked at. In light of this change, I think remoteIp can have some of its code removed. |
|
Thanks. I changed the locations where it made sense. |
EraYaN
approved these changes
Sep 10, 2020
crobibero
approved these changes
Sep 10, 2020
PrplHaz4
added a commit
to PrplHaz4/jellyfin-docs
that referenced
this pull request
Oct 1, 2020
Some new features for 10.7 release... Health Check jellyfin/jellyfin#4045 Known Proxies jellyfin/jellyfin#4116 jellyfin/jellyfin-web#1917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For X-Forwarded-For to make sense it must be configured with a list of known proxies.