Clean up several minor issues and add TODOs #458
Conversation
|
Looks good, but I would add braces around the ones that don't have any. |
|
I didn't want to reformat the document past the very basic functional fixes. That would make this an even harder to read pull request. Should I still? |
|
Alright one can look though all static methods to find ones that should not exist. Or really should be on another class. Also the verbs are very often wrong. Tons of |
Add Argument*Exceptions now use proper nameof operators. Added exception messages to quite a few Argument*Exceptions. Fixed rethorwing to be proper syntax. Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling) Added some TODOs to log certain exceptions. Fix sln again. Fixed all AssemblyInfo's and added proper copyright (where I could find them) We live in *current year*. Fixed the use of braces. Fixed a ton of properties, and made a fair amount of functions static that should be and can be static. Made more Methods that should be static static. You can now use static to find bad functions! Removed unused variable. And added one more proper XML comment.
|
Currently failing Drone checks with this error: |
|
I know, the fix is in the build system commit. Didn’t want to put the same fix everywhere. I can pull it in here as well, if needed. |
|
Alright I added a merge commit made with |
|
When this get's merged, the drone build breaks. So I either pull in changes from the build PR to unbreak the drone builds or we merge that one this weekend as well. |
Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
Outdated
Show resolved
Hide resolved
|
The braces can be added in a big reformat/refactor PR. If this can be merged this weekend I can do it tomorrow. |
joshuaboniface
changed the title
Add
Argument*Exceptions now use propernameofoperators.Added exception messages to quite a few
Argument*Exceptions.Fixed re throwing to be proper syntax (without variable name).
Added a ton of null checks. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.