Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emby API keys to our own #540

Merged
merged 7 commits into from Jan 11, 2019

Conversation

Projects
4 participants
@joshuaboniface
Copy link
Member

commented Jan 10, 2019

Updates the 5 API keys that I've been able to find, to our own API keys. All of these, where applicable, have been registered using a new account with the name "jellyfin" and the email address "team@jellyfin.org". This removes our dependency on the Emby API keys.

We should probably move these out of the deep-in-code, hardcoded locations they're currently in, but that can be a future project as we make them configurable from the UI.

Fixes #36

@anthonylavado

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@joshuaboniface Oooh I have the OpenSubtitles stuff too. Let me share that to you.

@anthonylavado
Copy link
Member

left a comment

If it means anything, I approve the other changes in this. Since I've added a commit, it would be good to get another approval that OKs that too.

@anthonylavado anthonylavado added this to In progress in 10.0.2 Update via automation Jan 10, 2019

@joshuaboniface joshuaboniface requested review from nvllsvm and JustAMan Jan 11, 2019

10.0.2 Update automation moved this from In progress to Reviewer approved Jan 11, 2019

@nvllsvm nvllsvm merged commit fcfb2fb into jellyfin:dev Jan 11, 2019

1 check passed

continuous-integration/drone/pr Build is passing
Details

10.0.2 Update automation moved this from Reviewer approved to Done Jan 11, 2019

@@ -20,7 +20,7 @@ public class MovieDbSearch
private static readonly CultureInfo EnUs = new CultureInfo("en-US");
private const string Search3 = MovieDbProvider.BaseMovieDbUrl + @"3/search/{3}?api_key={1}&query={0}&language={2}";

internal static string ApiKey = "f6bd687ffa63cd282b6ff2c6877f2669";
internal static string ApiKey = "4219e299c89411838049ab0dab19ebd5";

This comment has been minimized.

Copy link
@JustAMan

JustAMan Jan 11, 2019

Member

I don't like the duplication, but that's for another cleanup I think...
Ideally these should go to some configuration files rather than being embedded in the code.

This comment has been minimized.

Copy link
@joshuaboniface

joshuaboniface Jan 11, 2019

Author Member

Yup I 100% agree but fixing that is a bit out of my element for now ;-)

@joshuaboniface joshuaboniface added this to In progress in 10.0.2 Release Jan 15, 2019

@joshuaboniface joshuaboniface moved this from In progress to Done in 10.0.2 Release Jan 16, 2019

@joshuaboniface joshuaboniface deleted the joshuaboniface:api-keys branch Jan 16, 2019

@joshuaboniface joshuaboniface referenced this pull request Jan 16, 2019

Merged

Master 10.0.2 #592

@drakus72 drakus72 referenced this pull request Jan 16, 2019

Closed

TVDB API key #595

@joshuaboniface joshuaboniface referenced this pull request Jan 21, 2019

Merged

Release 10.1.0 #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.