Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace custom image parser with Skia #582
Simplifies our code a little bit. Note that this is slower than the old method, but not enough to warrant the old code.
When skia was the first to read, an 48 distinct executions average to:
When original was the first to read, an 48 distinct executions average to:
When externallib was the first to read, an 48 distinct executions average to:
Apart from the simplification, was the original code defective?
As an alternative to SkiaSharp, has System.Drawing been considered, which apparently can give you the dimensions without loading the entire image:
Yes original was cut+paste from StackOverflow.
Regarding my System.Drawing comment, it seems that route was Win32 only until relatively recently. There now exists a Window Compatibility NuGet Package which offers it:
...but we're probably best avoiding that beast??