Disambiguate vpx to vp8 or vp9 #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
reviewed
Aug 20, 2021
crobibero
approved these changes
Aug 21, 2021
| int defaultVp9Crf = 31; | ||
| if (h265Crf >= 0 && h265Crf <= 51) | ||
| { | ||
| var vp9Crf = Convert.ToInt32(h265Crf * 1.12); |
There was a problem hiding this comment.
I added a comment in the code, but I'll reproduce it here for posterity.
This conversion factor is chosen to match the default CRF for H.265 to the recommended 1080p CRF from Google. The factor also maps the logarithmic CRF scales of x265 [0, 51] to that of VP9 [0, 63] relatively
Resources:
cvium
reviewed
Aug 25, 2021
cvium
reviewed
Aug 25, 2021
| if (threads <= 0) | ||
| { | ||
| return 0; | ||
| // Automatically set thread count | ||
| return mustSetThreadCount ? Math.Max(Environment.ProcessorCount - 1, 1) : 0; | ||
| } | ||
| else if (threads >= Environment.ProcessorCount) |
There was a problem hiding this comment.
This is higher than the recommended value for vpx, is it not?
There was a problem hiding this comment.
This does not change the behavior from before, but no, vpx with -row-mt enabled should be able to exploit row-based parallelism during encoding (in addition to any tile-based parallelism).
jellyfin-bot
added
the
merge conflict
jellyfin-bot
removed
the
merge conflict
cvium
approved these changes
Sep 3, 2021
|
Squashed intermediate change commits so feel free to merge whenever :) |
Bond-009
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently,
vpxis being sent by clients to refer to the VP8/VP9 codecs ambiguously when indicating transcoding jobs. This change disambiguates between them in the server while providing backwards compatibility with codecs set asvpx, defaulting to VP8 as the codec. Additionally, as a part of this change, proper encoding support for VP9 is implemented leveraginglibvpx-vp9.Issues
Progress on #6455