Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix segment_time_delta for ffmpeg 4.1" #664

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
2 participants
@joshuaboniface
Copy link
Member

commented Jan 22, 2019

Reverts #639

CC @Bond-009

After more extensive testing, it looks like this change resulted in both the "End of Episode Skip" bug, which only seems present with this PR in and ffmpeg 4.1, as well as breaking support for skipping around videos with ffmpeg <4.1. #659 does not appear to make a difference to ffmpeg skip support, and hence makes testing the EoES bug very difficult. I'm able to confirm from testing that the EoES bug was eliminated once this PR was reverted (using ffmpeg 3.2 and 4.0), and this also ensures that we continue to support older ffmpeg versions which are in Debian Stable and similar distros for now. We should revisit supporting 4.1 in more detail after release as it appears more work is required.

Closes #659

@joshuaboniface joshuaboniface added this to In progress in 10.1.0 Release via automation Jan 22, 2019

10.1.0 Release automation moved this from In progress to Reviewer approved Jan 22, 2019

@nvllsvm nvllsvm merged commit 7509acf into release-10.1.0 Jan 22, 2019

2 checks passed

continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details

10.1.0 Release automation moved this from Reviewer approved to Done Jan 22, 2019

@nvllsvm nvllsvm deleted the revert-639-ffmpeg4.1 branch Jan 23, 2019

@doguitar doguitar referenced this pull request Jun 7, 2019

Closed

Resuming doesn't work #1301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.