Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement support for plugin repository #774

Merged
merged 8 commits into from Feb 3, 2019

Conversation

Projects
5 participants
@dkanada
Copy link
Contributor

commented Jan 30, 2019

I can successfully view the two plugins listed at the new location but haven't been able to test installations because the files don't exist yet. @joshuaboniface the hash should be MD5 and the runtimes field should be changed to netframework,netcore for both plugins. I think the timestamp is supposed to be build time so it can be used for sorting by date in the future but it can probably be an arbitrary value for now. It needs to be in the format 2018-12-15 10:00:00 which I am hoping is some kind of standard syntax for time values.


public PluginUpdateTask(ILogger logger, IInstallationManager installationManager, IApplicationHost appHost)
{
_logger = logger;

This comment has been minimized.

Copy link
@JustAMan

JustAMan Jan 30, 2019

Member

I think some of last PRs changed stuff to accept ILoggerFactory and create logger instance themselves. You probably have to follow that. Though I'm not 100% sure if that change hit the tasks...

This comment has been minimized.

Copy link
@dkanada

dkanada Jan 31, 2019

Author Contributor

I only matched the other tasks so I am not sure this needs to change until all the other tasks are updated.

Show resolved Hide resolved Emby.Server.Implementations/ScheduledTasks/PluginUpdateTask.cs Outdated
@joshuaboniface

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

An updated manifest.json along with 5 properly-built plugins is up.

@dkanada

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

One more thing, there were three scheduled tasks that were hidden from the web interface for some reason. I unhid them and cleaned up the code around there a bit. There was one task in another location but I'm not sure if we should leave it where it is or not.

@JustAMan
Copy link
Member

left a comment

Mostly fine except rounding stuff.

@hawken93

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

There's a rabbit hole of things to fix regarding plugins. There's some crap in E.S.I/ApplicationHost.cs around line 1630 that could be looked at, the GetAvailablePackagesWithoutRegistrationInfo is now redundant and should be refactored away, MediaBrowser.Api/PluginService.cs includes a bunch of dead endpoints. The frontend passes useless parameters that we have no reason to care about and the frontend also has crap lying around.

TLDR these are just my discoveries from independently trying to do this, there is lots of flesh to trim..

Just want to add that this is just for the record so that it can be remembered later. I think this PR is fine as long as it works. Good job :D

@JustAMan
Copy link
Member

left a comment

LGTM

@JustAMan

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@dkanada seems there's a merge conflict, can you fix it?

@JustAMan JustAMan added this to In progress in 10.2.0 Release via automation Feb 3, 2019

@JustAMan JustAMan merged commit a50fb92 into jellyfin:master Feb 3, 2019

10.2.0 Release automation moved this from In progress to Done Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.