Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup around the api endpoints #798

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
3 participants
@Bond-009
Copy link
Member

commented Feb 2, 2019

  • Made some proper async
  • Drop the use of the IProcess wrapper
  • Properly dispose
  • Remove unused fields

@Bond-009 Bond-009 force-pushed the Bond-009:apientrypoint branch from 5a6aa17 to cb7bffc Feb 3, 2019

@JustAMan
Copy link
Member

left a comment

LGTM

{
if (!_isPaused)
{
_logger.LogDebug("Sending pause command to ffmpeg");

try
{
_job.Process.StandardInput.Write("c");
await _job.Process.StandardInput.WriteAsync("c");

This comment has been minimized.

Copy link
@JustAMan

JustAMan Feb 3, 2019

Member

mental note: look into ffmpeg stdin interface, the way Jellyfin handles throttling now is it pauses transcoding by entering c and resumes by writing a newline.

@JustAMan JustAMan merged commit 83af2db into jellyfin:master Feb 4, 2019

@anthonylavado anthonylavado added this to Done in 10.2.0 Release Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.