Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment TMDB tags with original language #8889

Closed
wants to merge 1 commit into from
Closed

Augment TMDB tags with original language #8889

wants to merge 1 commit into from

Conversation

bradbeattie
Copy link
Contributor

@bradbeattie bradbeattie commented Dec 11, 2022

Changes
When generating tag metadata from TMDB, include the original language as a tag (e.g. lang-en or lang-fr).

The intent here is to piggyback on SqliteItemRepository's use of tags to determine item similarity to also consider a movie's original (primary) language. The result being that Jellyfin's "More Like This" would give some relevance to a movie's language.

Furthermore, in concert with #8842 this change would allow searching for content by language.

Issues

Partially addresses https://features.jellyfin.org/posts/39/filter-videos-by-audio-stream-language

@bradbeattie bradbeattie marked this pull request as draft December 11, 2022 20:11
@bradbeattie bradbeattie closed this by deleting the head repository Dec 11, 2022
@bradbeattie bradbeattie reopened this Dec 11, 2022
@bradbeattie
Copy link
Contributor Author

GitHub actions are showing a failure, though I suspect it isn't my code change but instead related to the dotnet 6->7 changes commited within the last 72 hours. I'll revisit this PR when that's resolved.

@bradbeattie bradbeattie marked this pull request as ready for review December 16, 2022 02:33
@bradbeattie
Copy link
Contributor Author

Closed and reopened as #8916. I suspect the dotnet changes have made their way in, but I couldn't seem to find a way to kick off the Github actions again without reopening the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant