Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stereo downmix algorithm selection. #9001

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Shadowghost
Copy link
Contributor

Implements different downmixing algorithms from https://superuser.com/questions/852400/properly-downmix-5-1-to-stereo-using-ffmpeg/1410620#1410620 which were discussed in #1986

Changes

  • Add stereo downmixing algorithms

Issues
Fixes #1986

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be configured manually in the encoding.xml config file or do you plan to expose it in the API so it can be changed in the playback section in the dashboard?

@Shadowghost
Copy link
Contributor Author

Shadowghost commented Jan 3, 2023

If we have a final list of algorithms I plan on implementing a settings drop-down in web for it.

Implemented with jellyfin/jellyfin-web#4235

@Shadowghost Shadowghost force-pushed the stereo-downmix branch 2 times, most recently from b109851 to bebada9 Compare January 9, 2023 07:10
@crobibero crobibero requested a review from a team January 9, 2023 15:36
@Bond-009 Bond-009 merged commit 3a7a781 into jellyfin:master Jan 12, 2023
@Shadowghost Shadowghost deleted the stereo-downmix branch January 23, 2023 08:09
@false
Copy link

false commented Nov 12, 2023

How do you currently use this feature ? It seems it is not visible in the playback menu, and editing the encoding.xml by adding <DownmixStereoAlgorithms>1</DownmixStereoAlgorithms> for exemple, just gets reseted and disappears from the config file.

@Shadowghost
Copy link
Contributor Author

It is only available in unstable and it is a global server setting.

@Martan404
Copy link

Do you have any idea when we can expect to see it released to stable?

@Gauvino
Copy link
Contributor

Gauvino commented Apr 9, 2024

Do you have any idea when we can expect to see it released to stable?

29 of April 10.9 will be released with this changed in it

@gnattu
Copy link
Member

gnattu commented May 24, 2024

Is it possible to apply this globally? for all users

It is a global option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly Downmix 5.1 Audio
9 participants