-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metric for item counts #9290
base: master
Are you sure you want to change the base?
Conversation
|
@robertas90poe you approved the original PR for this not too long ago, could you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@cvium you had commented on the previous iteration of this PR, could you take a look? |
|
Honestly, it's not great that it relies on DB queries. The database is already heavily abused. |
|
Gotcha, I will look into ways to get the information without continuously querying the database when I have some free time. Thanks for taking a look. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
While the db queries here is less than great, it would be great to at least get some basic Jellyfin stuff in, like the Jellyfin version (something ala Do you think you could create a PR for something really basic, that doesn't depend on any db queries so we can get the ball rolling? |
|
Maybe querying the database is OK if there's a cache or if the target is only scraped every hour ? For this type of data I don't think the granularity needs to be by the minute... |
|
Personally, I think having it cached and then scraped at an interval is an acceptable solution, not necessarily ideal. I spent a little bit of time trying to figure out how to get that information without hitting the database, but I'm not familiar enough with the codebase (or C# really ) to have any success. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Is this PR still scheduled for a release? Having more data that could be exported for external metrics collectors would be great! |
|
Jellystat seems interesting but having a dedicated app only for jellyfin feels a litte bit too much. Using prometheus + grafana helps get all the data and visualisation at the same place. |
Changes
Updated the prometheus metrics endpoint written by @holahmeds in #6882 to be up to date with main.
Adds
jellyfin_library_items_totalto the metrics endpoint which will return the amount of every item in the library.Issues
Contributes to #3016