fix: skip library folders that are inaccessible or empty #9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvium
commented
Feb 10, 2023
JPVenson
approved these changes
Jan 2, 2024
|
Any update on this? This is still a very bad problem. Especially since rescan takes like days for a library of few TBs. |
crobibero
approved these changes
Mar 18, 2024
Bond-009
approved these changes
Mar 18, 2024
1 task
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
IDisposable
pushed a commit
to IDisposable/jellyfin-jellyfin
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FolderwhereIsTopParent == trueif the filesystem path is inaccessible or emptyIsRootis true (AggregateFolder and UserRootFolder will have this condition and they directly point to library folders)I have only tested it on Windows with SMB mount and an empty folder. It needs to be tested more, especially Linux network shares, symlinks etc.
Issues