Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to playlists not created by a user #9746

Merged
merged 1 commit into from
May 12, 2023
Merged

Fix access to playlists not created by a user #9746

merged 1 commit into from
May 12, 2023

Conversation

Shadowghost
Copy link
Contributor

@Shadowghost Shadowghost commented May 9, 2023 •
edited
Loading

Changes

  • Introduce a new property OpenAccess to allow read access to the playlist for all users
  • Automatically set OpenAccess to true if the playlist originates from the file system and was not created by any user
  • Adopt playlist migration to handle those cases
  • Add 403 response code documentation to the PlaylistController endpoints

@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited
Loading

Changes in OpenAPI specification found. Expand to see details.

What's Changed

POST /Playlists/{playlistId}/Items/{itemId}/Move/{newIndex}
Return Type:

Changed response : 403 Forbidden

User does not have permission to move item.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

POST /Playlists
Return Type:

Changed response : 403 Forbidden

User does not have permission to create playlists.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

Changed response : 200 OK

Playlist created.

POST /Playlists/{playlistId}/Items
Return Type:

Changed response : 403 Forbidden

User does not have permission to add items to playlist.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

DELETE /Playlists/{playlistId}/Items
Return Type:

Changed response : 403 Forbidden

User does not have permission to get playlist.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

GET /Playlists/{playlistId}/Items
Return Type:

Changed response : 404 Not Found

Playlist not found.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

Changed response : 403 Forbidden

User does not have permission to get playlist items.

  • New content type : application/json

  • New content type : application/json; profile="CamelCase"

  • New content type : application/json; profile="PascalCase"

@Shadowghost Shadowghost requested a review from crobibero May 12, 2023 08:54
@crobibero crobibero merged commit a8cdf44 into jellyfin:master May 12, 2023
This was referenced May 26, 2023
Merged
Closed
@crobibero crobibero mentioned this pull request Jun 20, 2023
Closed
@cewert cewert mentioned this pull request Jun 28, 2023
Closed
@felix920506 felix920506 mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shadowghost @nielsvanvelzen @crobibero