Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ffmpeg compatibility #991

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
4 participants
@joshuaboniface
Copy link
Member

commented Feb 24, 2019

Changes
Doing this the other way was just complex and prone to failures with various usecases involving other ffmpegs. No longer try to override the system ffmpeg, just put ours somewhere else and depend on that package entirely for all Debian/Ubuntu releases.

Requires a rebuild of the jellyfin-ffmpeg package which is forthcoming.

Issues
Fixes #974

@joshuaboniface joshuaboniface changed the base branch from master to release-10.2.z Feb 24, 2019

@joshuaboniface joshuaboniface added this to To do in 10.2.2 Hotfix Feb 24, 2019

Fix the ffmpeg compatibility
Doing this the other way was just complex. No longer try to override
the system ffmpeg, just put ours somewhere else and depend on that
package.

@joshuaboniface joshuaboniface force-pushed the joshuaboniface:ffmpeg-compat branch from 9856f9f to 5054a77 Feb 25, 2019

@JustAMan
Copy link
Member

left a comment

I still feel we'd better put our stuff under /opt/jellyfin-ffmpeg, but that is personal. Should be good either way.

@joshuaboniface joshuaboniface requested a review from jellyfin/core Feb 26, 2019

@joshuaboniface

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

Confirmed with significant testing that the ffmpeg build works. Will be pushed and released along with the release.

@joshuaboniface

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

Completed ffmpeg build: jellyfin/jellyfin-ffmpeg@0966a03

@nvllsvm nvllsvm merged commit f384822 into jellyfin:release-10.2.z Feb 28, 2019

1 check passed

continuous-integration/drone/pr Build is passing
Details

@joshuaboniface joshuaboniface moved this from To do to Done in 10.2.2 Hotfix Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.