dul-receive-pack doesn't match git-receive-pack #71

Closed
jonchu opened this Issue Aug 30, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

jonchu commented Aug 30, 2012

When running dul-receive-pack on a repository I get this output:

005a23b87ffabd30448e05e1e28cafa660e4580fbb3a HEADreport-status delete-refs side-band-64k
004023b87ffabd30448e05e1e28cafa660e4580fbb3a refs/heads/branch2
003f5130a31543f90c68636a676e203ba2a975b713e7 refs/heads/master
0000

Whereas, git-receive-pack gives:
007923b87ffabd30448e05e1e28cafa660e4580fbb3a refs/heads/branch2 report-status delete-refs side-band-64k quiet ofs-delta
003f5130a31543f90c68636a676e203ba2a975b713e7 refs/heads/master
0000

I'm not sure if the extra line describing HEAD is an issue. However, the missing space between HEAD and report-status should cause the send-pack process to parse the capabilities incorrectly.

Owner

jelmer commented Sep 1, 2012

On Thu, Aug 30, 2012 at 01:13:23PM -0700, jchonphoenix wrote:

When running dul-receive-pack on a repository I get this output:

005a23b87ffabd30448e05e1e28cafa660e4580fbb3a HEADreport-status delete-refs side-band-64k
004023b87ffabd30448e05e1e28cafa660e4580fbb3a refs/heads/branch2
003f5130a31543f90c68636a676e203ba2a975b713e7 refs/heads/master
0000

Whereas, git-receive-pack gives:
007923b87ffabd30448e05e1e28cafa660e4580fbb3a refs/heads/branch2 report-status delete-refs side-band-64k quiet ofs-delta
003f5130a31543f90c68636a676e203ba2a975b713e7 refs/heads/master
0000

I'm not sure if the extra line describing HEAD is an issue.
I guess dulwich should be consistent with git in that regard, so it
would be nice to remove the HEAD reference.

However, the missing space between HEAD and report-status should cause the send-pack process to parse the capabilities incorrectly.
That's not just a space though - the significant bit is the \0
character after the ref. I'm not sure if capabilities should always
start with a space; we'd have to check the docs (and C git behaviour)
about that.

Cheers,

Jelmer

jelmer added the bug label Jan 18, 2015

Owner

jelmer commented May 24, 2015

The extra space is now included in master.

jelmer closed this May 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment